Merge into trunk : better-error-bug-1064212 : Code : MAAS

Status:

Merged

Approved by:

Julian Edwards on 2014-01-16

Approved revision:

no longer in the source branch.

Merged at revision:

1819

Proposed branch:

lp:~julian-edwards/maas/better-error-bug-1064212

Merge into:

lp:~maas-committers/maas/trunk

Diff against target:

22 lines (+10/-2)

1 file modified

src/provisioningserver/pxe/config.py (+10/-2)

To merge this branch:

bzr merge lp:~julian-edwards/maas/better-error-bug-1064212

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Jeroen T. Vermeulen (community)		2014-01-16	Approve on 2014-01-16
Review via email: mp+201883@code.launchpad.net

Commit message

Expand the error message for missing pxe templates to offer a hint about why they are missing.

Description of the change

This doesn't attempt to fix the underlying problem - that is caused when the purpose "poweroff" is used, for which we have no templates (I don't think you can use pxeconfig to turn a machine off).

Ultimately the problem is caused by PEBKAC, that is someone manually turned on a machine when they should not have. The best course of action is to have a descriptive error message that schools them in the error of their ways.

Revision history for this message

Jeroen T. Vermeulen (jtv) wrote on 2014-01-16:

#

It's good to have a stopgap. Guesswork remains unpleasant, especially when we ask the user to look up information that we have at hand. After all we request information about the node from the API (see pxeconfig() in maasserver/api.py) just before it gets to this point. AFAICS that information could easily be made to include something that tells the tftp server whether the node is supposed to be netbooting right now. If we had that, we could issue a more definite "hands off, this node boots when MAAS says so" message.

The "when MAAS is not expecting that" sounds a little vague, as we're not sure ourselves what is supposed to be happening, or MAAS just felt like dozing off for a bit. Maybe "when it's not supposed to," or "when it's not in a state where MAAS allows it"?

I suppose the error could also happen if the node's state is changed in rapid succession, e.g. if it is allocated and immediately deallocated.

review: Approve

Revision history for this message

Julian Edwards (julian-edwards) wrote on 2014-01-16:

#

On 16/01/14 17:51, Jeroen T. Vermeulen wrote:
> Review: Approve
>
> It's good to have a stopgap. Guesswork remains unpleasant, especially when we ask the user to look up information that we have at hand. After all we request information about the node from the API (see pxeconfig() in maasserver/api.py) just before it gets to this point. AFAICS that information could easily be made to include something that tells the tftp server whether the node is supposed to be netbooting right now. If we had that, we could issue a more definite "hands off, this node boots when MAAS says so" message.

True, but "purpose" is just as good here.

> The "when MAAS is not expecting that" sounds a little vague, as we're not sure ourselves what is supposed to be happening, or MAAS just felt like dozing off for a bit. Maybe "when it's not supposed to," or "when it's not in a state where MAAS allows it"?

I'll re-word it.

> I suppose the error could also happen if the node's state is changed in rapid succession, e.g. if it is allocated and immediately deallocated.

Possibly yes. But unlikely, I hope.

Thanks for the review!

Revision history for this message

MAAS Lander (maas-lander) wrote on 2014-01-16:

#

Download full text (17.7 KiB)

The attempt to merge lp:~julian-edwards/maas/better-error-bug-1064212 into lp:maas failed. Below is the output from the failed tests.

Ign http://security.ubuntu.com saucy-security InRelease
Get:1 http://security.ubuntu.com saucy-security Release.gpg [933 B]
Ign http://nova.clouds.archive.ubuntu.com saucy InRelease
Get:2 http://security.ubuntu.com saucy-security Release [49.6 kB]
Ign http://nova.clouds.archive.ubuntu.com saucy-updates InRelease
Hit http://nova.clouds.archive.ubuntu.com saucy Release.gpg
Get:3 http://nova.clouds.archive.ubuntu.com saucy-updates Release.gpg [933 B]
Hit http://nova.clouds.archive.ubuntu.com saucy Release
Get:4 http://nova.clouds.archive.ubuntu.com saucy-updates Release [49.6 kB]
Get:5 http://security.ubuntu.com saucy-security/main Sources [23.9 kB]
Hit http://nova.clouds.archive.ubuntu.com saucy/main Sources
Get:6 http://security.ubuntu.com saucy-security/universe Sources [7,454 B]
Hit http://nova.clouds.archive.ubuntu.com saucy/universe Sources
Get:7 http://security.ubuntu.com saucy-security/main amd64 Packages [68.8 kB]
Hit http://nova.clouds.archive.ubuntu.com saucy/main amd64 Packages
Hit http://nova.clouds.archive.ubuntu.com saucy/universe amd64 Packages
Hit http://nova.clouds.archive.ubuntu.com saucy/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy/universe Translation-en
Get:8 http://security.ubuntu.com saucy-security/universe amd64 Packages [26.4 kB]
Hit http://security.ubuntu.com saucy-security/main Translation-en
Hit http://security.ubuntu.com saucy-security/universe Translation-en
Ign http://security.ubuntu.com saucy-security/main Translation-en_US
Get:9 http://nova.clouds.archive.ubuntu.com saucy-updates/main Sources [62.8 kB]
Get:10 http://nova.clouds.archive.ubuntu.com saucy-updates/universe Sources [43.0 kB]
Get:11 http://nova.clouds.archive.ubuntu.com saucy-updates/main amd64 Packages [184 kB]
Ign http://security.ubuntu.com saucy-security/universe Translation-en_US
Get:12 http://nova.clouds.archive.ubuntu.com saucy-updates/universe amd64 Packages [126 kB]
Hit http://nova.clouds.archive.ubuntu.com saucy-updates/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy-updates/universe Translation-en
Ign http://nova.clouds.archive.ubuntu.com saucy/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy/universe Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy-updates/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy-updates/universe Translation-en_US
Fetched 643 kB in 0s (2,240 kB/s)
Reading package lists...
sudo DEBIAN_FRONTEND=noninteractive apt-get -y \
--no-install-recommends install apache2 avahi-daemon avahi-utils bind9 bind9utils build-essential curl daemontools distro-info dnsutils firefox freeipmi-tools ipython isc-dhcp-common libjs-raphael libjs-yui3-full libjs-yui3-min libpq-dev make postgresql-9.1 python-amqplib python-avahi python-bzrlib python-celery python-convoy python-cssselect python-curtin python-dbus python-dev python-distro-info python-django python-django-piston python-django-south python-djorm-ext-pgarray python-docutils python-formencode python-httplib2 python-jinja2 python-lockfile python...

The attempt to merge lp:~julian-edwards/maas/better-error-bug-1064212 into lp:maas failed. Below is the output from the failed tests.

Ign http://security.ubuntu.com saucy-security InRelease
Get:1 http://security.ubuntu.com saucy-security Release.gpg [933 B]
Ign http://nova.clouds.archive.ubuntu.com saucy InRelease
Get:2 http://security.ubuntu.com saucy-security Release [49.6 kB]
Ign http://nova.clouds.archive.ubuntu.com saucy-updates InRelease
Hit http://nova.clouds.archive.ubuntu.com saucy Release.gpg
Get:3 http://nova.clouds.archive.ubuntu.com saucy-updates Release.gpg [933 B]
Hit http://nova.clouds.archive.ubuntu.com saucy Release
Get:4 http://nova.clouds.archive.ubuntu.com saucy-updates Release [49.6 kB]
Get:5 http://security.ubuntu.com saucy-security/main Sources [23.9 kB]
Hit http://nova.clouds.archive.ubuntu.com saucy/main Sources
Get:6 http://security.ubuntu.com saucy-security/universe Sources [7,454 B]
Hit http://nova.clouds.archive.ubuntu.com saucy/universe Sources
Get:7 http://security.ubuntu.com saucy-security/main amd64 Packages [68.8 kB]
Hit http://nova.clouds.archive.ubuntu.com saucy/main amd64 Packages
Hit http://nova.clouds.archive.ubuntu.com saucy/universe amd64 Packages
Hit http://nova.clouds.archive.ubuntu.com saucy/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy/universe Translation-en
Get:8 http://security.ubuntu.com saucy-security/universe amd64 Packages [26.4 kB]
Hit http://security.ubuntu.com saucy-security/main Translation-en
Hit http://security.ubuntu.com saucy-security/universe Translation-en
Ign http://security.ubuntu.com saucy-security/main Translation-en_US
Get:9 http://nova.clouds.archive.ubuntu.com saucy-updates/main Sources [62.8 kB]
Get:10 http://nova.clouds.archive.ubuntu.com saucy-updates/universe Sources [43.0 kB]
Get:11 http://nova.clouds.archive.ubuntu.com saucy-updates/main amd64 Packages [184 kB]
Ign http://security.ubuntu.com saucy-security/universe Translation-en_US
Get:12 http://nova.clouds.archive.ubuntu.com saucy-updates/universe amd64 Packages [126 kB]
Hit http://nova.clouds.archive.ubuntu.com saucy-updates/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy-updates/universe Translation-en
Ign http://nova.clouds.archive.ubuntu.com saucy/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy/universe Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy-updates/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy-updates/universe Translation-en_US
Fetched 643 kB in 0s (2,240 kB/s)
Reading package lists...
sudo DEBIAN_FRONTEND=noninteractive apt-get -y \
	    --no-install-recommends install apache2 avahi-daemon avahi-utils bind9 bind9utils build-essential curl daemontools distro-info dnsutils firefox freeipmi-tools ipython isc-dhcp-common libjs-raphael libjs-yui3-full libjs-yui3-min libpq-dev make postgresql-9.1 python-amqplib python-avahi python-bzrlib python-celery python-convoy python-cssselect python-curtin python-dbus python-dev python-distro-info python-django python-django-piston python-django-south python-djorm-ext-pgarray python-docutils python-formencode python-httplib2 python-jinja2 python-lockfile python-lxml python-netaddr python-netifaces python-oauth python-oops python-oops-amqp python-oops-datedir-repo python-oops-twisted python-oops-wsgi python-pip python-pocket-lint python-psycopg2 python-pyinotify python-simplestreams python-sphinx python-tempita python-twisted python-txamqp python-txlongpoll python-txtftp python-virtualenv python-yaml rabbitmq-server syslinux-common tgt ubuntu-cloudimage-keyring wget xvfb
Reading package lists...
Building dependency tree...
Reading state information...
build-essential is already the newest version.
distro-info is already the newest version.
freeipmi-tools is already the newest version.
isc-dhcp-common is already the newest version.
libjs-raphael is already the newest version.
libjs-yui3-full is already the newest version.
libjs-yui3-min is already the newest version.
make is already the newest version.
python-amqplib is already the newest version.
python-bzrlib is already the newest version.
python-celery is already the newest version.
python-convoy is already the newest version.
python-dbus is already the newest version.
python-dev is already the newest version.
python-distro-info is already the newest version.
python-django is already the newest version.
python-django-piston is already the newest version.
python-django-south is already the newest version.
python-djorm-ext-pgarray is already the newest version.
python-docutils is already the newest version.
python-formencode is already the newest version.
python-httplib2 is already the newest version.
python-jinja2 is already the newest version.
python-lockfile is already the newest version.
python-lxml is already the newest version.
python-netaddr is already the newest version.
python-netifaces is already the newest version.
python-oauth is already the newest version.
python-oops is already the newest version.
python-oops-amqp is already the newest version.
python-oops-datedir-repo is already the newest version.
python-oops-twisted is already the newest version.
python-oops-wsgi is already the newest version.
python-psycopg2 is already the newest version.
python-pyinotify is already the newest version.
python-sphinx is already the newest version.
python-tempita is already the newest version.
python-twisted is already the newest version.
python-txamqp is already the newest version.
python-txlongpoll is already the newest version.
python-txtftp is already the newest version.
python-yaml is already the newest version.
rabbitmq-server is already the newest version.
syslinux-common is already the newest version.
tgt is already the newest version.
ubuntu-cloudimage-keyring is already the newest version.
wget is already the newest version.
daemontools is already the newest version.
ipython is already the newest version.
python-cssselect is already the newest version.
python-pip is already the newest version.
python-pocket-lint is already the newest version.
python-virtualenv is already the newest version.
apache2 is already the newest version.
avahi-daemon is already the newest version.
avahi-utils is already the newest version.
bind9 is already the newest version.
bind9utils is already the newest version.
curl is already the newest version.
dnsutils is already the newest version.
firefox is already the newest version.
libpq-dev is already the newest version.
postgresql-9.1 is already the newest version.
python-avahi is already the newest version.
python-curtin is already the newest version.
python-simplestreams is already the newest version.
xvfb is already the newest version.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
make -C acceptance clean
make[1]: Entering directory `/tmp/tarmac/branch.2QcMts/acceptance'
rm -f -r source build *.build *.changes *.deb
make[1]: Leaving directory `/tmp/tarmac/branch.2QcMts/acceptance'
find . -type f -name '*.py[co]' -print0 | xargs -r0 rm -f
find . -type f -name '*~' -print0 | xargs -r0 rm -f
find . -type f -name dropin.cache -print0 | xargs -r0 rm -f
rm -f -r media/demo/* media/development
rm -f src/maasserver/static/js/enums.js
rm -f *.log
rm -f docs/api.rst
rm -f -r docs/_autosummary docs/_build
rm -f -r man/.doctrees
rm -f -r bin include lib local
rm -f -r eggs develop-eggs
rm -f -r build dist logs/* parts
rm -f tags TAGS .installed.cfg
rm -f -r *.egg *.egg-info src/*.egg-info
rm -f -r run/* services/*/supervise
virtualenv --python=python2.7 --system-site-packages /tmp/tarmac/branch.2QcMts
New python executable in /tmp/tarmac/branch.2QcMts/bin/python2.7
Also creating executable in /tmp/tarmac/branch.2QcMts/bin/python
Installing Setuptools...................................................................................................................................................................................................................................done.
Installing Pip..........................................................................................................................................................................................................................................................................................................................................done.
Running virtualenv with interpreter /usr/bin/python2.7
bin/pip --quiet install --ignore-installed \
	    --no-dependencies bootstrap/zc.buildout-1.5.2.tar.gz
rm -f -f README.txt  # zc.buildout installs an annoying README.txt.
bin/buildout install database
Creating directory '/tmp/tarmac/branch.2QcMts/parts'.
Creating directory '/tmp/tarmac/branch.2QcMts/develop-eggs'.
Installing database.
Generated script '/tmp/tarmac/branch.2QcMts/bin/database'.
bin/buildout install repl
Installing repl.
Generated script '/tmp/tarmac/branch.2QcMts/bin/ipy'.
Generated interpreter '/tmp/tarmac/branch.2QcMts/bin/py'.
bin/py -m src/maasserver/utils/jsenums src/maasserver/enum.py src/metadataserver/enum.py src/provisioningserver/enum.py > src/maasserver/static/js/enums.js
bin/buildout install maas
Installing maas.
Generated script '/tmp/tarmac/branch.2QcMts/bin/celeryd.region'.
Generated script '/tmp/tarmac/branch.2QcMts/bin/maas'.
bin/buildout install maas-test
Installing maas-test.
Generated script '/tmp/tarmac/branch.2QcMts/bin/test.maas'.
bin/buildout install maascli
Installing maascli.
Generated script '/tmp/tarmac/branch.2QcMts/bin/maascli'.
bin/buildout install maascli-test
Installing maascli-test.
Generated script '/tmp/tarmac/branch.2QcMts/bin/test.maascli'.
bin/buildout install maastesting-test
Installing maastesting-test.
Generated script '/tmp/tarmac/branch.2QcMts/bin/test.maastesting'.
bin/buildout install pserv
Installing pserv.
Generated script '/tmp/tarmac/branch.2QcMts/bin/celeryd.cluster'.
Generated script '/tmp/tarmac/branch.2QcMts/bin/maas-provision'.
Generated script '/tmp/tarmac/branch.2QcMts/bin/twistd.pserv'.
bin/buildout install pserv-test
Installing pserv-test.
Generated script '/tmp/tarmac/branch.2QcMts/bin/test.pserv'.
bin/buildout install maas-probe-dhcp
Installing maas-probe-dhcp.
Generated script '/tmp/tarmac/branch.2QcMts/bin/maas-probe-dhcp'.
bin/buildout install txlongpoll
Installing txlongpoll.
Generated script '/tmp/tarmac/branch.2QcMts/bin/twistd.txlongpoll'.
make -C acceptance clean
make[1]: Entering directory `/tmp/tarmac/branch.2QcMts/acceptance'
rm -f -r source build *.build *.changes *.deb
make[1]: Leaving directory `/tmp/tarmac/branch.2QcMts/acceptance'
find . -type f -name '*.py[co]' -print0 | xargs -r0 rm -f
find . -type f -name '*~' -print0 | xargs -r0 rm -f
find . -type f -name dropin.cache -print0 | xargs -r0 rm -f
rm -f -r media/demo/* media/development
rm -f src/maasserver/static/js/enums.js
rm -f *.log
rm -f docs/api.rst
rm -f -r docs/_autosummary docs/_build
rm -f -r man/.doctrees
bin/py -m src/maasserver/utils/jsenums src/maasserver/enum.py src/metadataserver/enum.py src/provisioningserver/enum.py > src/maasserver/static/js/enums.js
bin/buildout install maas
Updating maas.
bin/buildout install maas-test
Updating maas-test.
bin/buildout install maas
Updating maas.
echo bin/test.maas bin/test.maascli bin/test.maastesting bin/test.pserv | xargs -n1 env
nosetests --exclude=provisioningserver --exclude=maastesting --exclude=maascli --verbosity=1
Creating test database for alias 'default'...
Destroying test database for alias 'default'...

..S.....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................E.....................................................................................................................................................................................................................................................................................................................................................................................................................................S.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
======================================================================
ERROR: maasserver.tests.test_dns.TestDNSConfigModifications.test_write_full_dns_loads_full_dns_config
----------------------------------------------------------------------
_StringException: named.log: {{{
info: additionally listening on IPv4 interface lo, 127.0.0.1#40798
error: could not listen on UDP socket: address in use
error: creating IPv4 interface lo failed; interface ignored
info: managed-keys-zone: loaded serial 0
notice: all zones loaded
notice: running
info: received control channel command 'reload'
info: loading configuration from '/tmp/tmpuwb4iT/named.conf'
info: reading built-in trusted keys from file '/etc/bind/bind.keys'
info: using default UDP/IPv4 port range: [1024, 65535]
info: using default UDP/IPv6 port range: [1024, 65535]
info: listening on IPv4 interface lo, 127.0.0.1#40798
error: could not listen on UDP socket: address in use
error: creating IPv4 interface lo failed; interface ignored
warning: not listening on any interfaces
info: sizing zone task pool based on 0 zones
notice: command channel listening on 127.0.0.1#58102
info: additionally listening on IPv4 interface lo, 127.0.0.1#40798
error: could not listen on UDP socket: address in use
error: creating IPv4 interface lo failed; interface ignored
info: reloading configuration succeeded
info: reloading zones succeeded
notice: all zones loaded
notice: running
info: received control channel command 'reload'
info: loading configuration from '/tmp/tmpuwb4iT/named.conf'
info: reading built-in trusted keys from file '/etc/bind/bind.keys'
info: using default UDP/IPv4 port range: [1024, 65535]
info: using default UDP/IPv6 port range: [1024, 65535]
info: listening on IPv4 interface lo, 127.0.0.1#40798
error: could not listen on UDP socket: address in use
error: creating IPv4 interface lo failed; interface ignored
warning: not listening on any interfaces
info: sizing zone task pool based on 2 zones
info: additionally listening on IPv4 interface lo, 127.0.0.1#40798
error: could not listen on UDP socket: address in use
error: creating IPv4 interface lo failed; interface ignored
info: reloading configuration succeeded
info: reloading zones succeeded
info: zone 0.168.192.in-addr.arpa/IN: loaded serial 35
info: zone nodegroup-lkBRFO/IN: loaded serial 35
notice: all zones loaded
notice: running
}}}

Traceback (most recent call last):
  File "/tmp/tarmac/branch.2QcMts/src/maasserver/tests/test_dns.py", line 277, in test_write_full_dns_loads_full_dns_config
    self.assertDNSMatches(node.hostname, nodegroup.name, lease.ip)
  File "/tmp/tarmac/branch.2QcMts/src/maasserver/tests/test_dns.py", line 220, in assertDNSMatches
    forward_lookup_result = self.dig_resolve(fqdn)
  File "/tmp/tarmac/branch.2QcMts/src/maasserver/tests/test_dns.py", line 209, in dig_resolve
    commands=[fqdn, '+short']).split('\n')
  File "/tmp/tarmac/branch.2QcMts/src/provisioningserver/testing/tests/test_bindfixture.py", line 60, in dig_call
    return check_output(cmd).strip()
  File "/usr/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command '[u'dig', u'+time=10', u'+tries=5', u'@127.0.0.1', u'-p', u'40798', u'OApH2nEjL0Z1Im1iTDRd.nodegroup-lkBRFO', u'+short']' returned non-zero exit status 9

----------------------------------------------------------------------
Ran 1928 tests in 252.478s

FAILED (SKIP=2, errors=1)
....................................................................................
----------------------------------------------------------------------
Ran 84 tests in 0.971s

OK
...................................................S..S......................................................
----------------------------------------------------------------------
Ran 109 tests in 1.780s

OK (SKIP=2)
...........................................................................................................................................................................................................................................................................................................................SSSS..................................................................................................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 689 tests in 26.382s

OK (SKIP=4)
make: *** [test] Error 123

 === modified file 'src/provisioningserver/pxe/config.py'
 --- src/provisioningserver/pxe/config.py	2013-10-07 09:12:40 +0000
 +++ src/provisioningserver/pxe/config.py	2014-01-16 09:35:24 +0000
@@ -71,8 +71,16 @@
              if error.errno != ENOENT:
                  raise
      else:
--        raise AssertionError(
--            "No PXE template found in %r!" % pxe_templates_dir)
++        error = (
++            "No PXE template found in %r for:\n"
++            "  Purpose: %r, Arch: %r, Subarch: %r\n"
++            "This can happen if you manually power up a node when its "
++            "state is not one that allows it. Is the node in the 'Declared' "
++            "or 'Ready' states? It needs to be Enlisting, Commissioning or "
++            "Allocated."
++                % (pxe_templates_dir, purpose, arch, subarch))
++
++        raise AssertionError(error)
  def render_pxe_config(kernel_params, **extra):

MAAS

Merge lp:~julian-edwards/maas/better-error-bug-1064212 into lp:~maas-committers/maas/trunk

Commit message

Description of the change

Preview Diff

Subscribers