Merge lp:~julian-edwards/maas/1.7-race-for-staticip-bug-1387262 into lp:maas/1.7
Proposed by
Julian Edwards
Status: | Merged |
---|---|
Approved by: | Julian Edwards |
Approved revision: | no longer in the source branch. |
Merged at revision: | 3297 |
Proposed branch: | lp:~julian-edwards/maas/1.7-race-for-staticip-bug-1387262 |
Merge into: | lp:maas/1.7 |
Diff against target: |
128 lines (+50/-11) 3 files modified
src/maasserver/locks.py (+3/-0) src/maasserver/models/staticipaddress.py (+22/-11) src/maasserver/models/tests/test_staticipaddress.py (+25/-0) |
To merge this branch: | bzr merge lp:~julian-edwards/maas/1.7-race-for-staticip-bug-1387262 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Reis (community) | Needs Information | ||
Julian Edwards (community) | Approve | ||
Review via email: mp+240800@code.launchpad.net |
Commit message
Backport r3337: Use a lock in the critical section of the code that finds and records a new static IP address in the database. Some users have reported errors in the PG log file complaining about inserting duplicates, so there must be a race.
To post a comment you must log in.
Approved for a backport by Andres earlier in the bug.