Merge lp:~julian-edwards/maas/1.6-packaging-no-rabbit-restarts into lp:~maas-maintainers/maas/packaging.trusty

Proposed by Julian Edwards
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 294
Merged at revision: 292
Proposed branch: lp:~julian-edwards/maas/1.6-packaging-no-rabbit-restarts
Merge into: lp:~maas-maintainers/maas/packaging.trusty
Diff against target: 55 lines (+19/-3)
3 files modified
debian/changelog (+13/-0)
debian/maas-region-controller.postinst (+5/-2)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~julian-edwards/maas/1.6-packaging-no-rabbit-restarts
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+231689@code.launchpad.net

Commit message

Ensure rabbit is not restarted unnecessarily on upgrades, and boost bzr revno to latest version

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Generally good, but this doesn't see any difference between “rabbit is completely broken and refused to start” and “everything's fine, rabbit's already running.” Is that a problem? If so, is there anything we can do about it?

review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

I honestly have no idea, we need a packaging expert. Thanks for reviewing1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-08-19 16:42:00 +0000
3+++ debian/changelog 2014-08-21 08:42:03 +0000
4@@ -1,3 +1,16 @@
5+maas (1.6.1+bzr2550-0ubuntu1~ppa1) trusty; urgency=medium
6+
7+ * New upstream bugfix release:
8+ - Auto-link node MACs to Networks (LP: #1341619)
9+
10+ [ Julian Edwards ]
11+ * debian/maas-region-controller.postinst: Don't restart RabbitMQ on
12+ upgrades, just ensure it's running. Should prevent a race with the
13+ cluster celery restarting.
14+ * debian/rules: Pull upstream branch from the right place.
15+
16+ -- Julian Edwards <julian.edwards@canonical.com> Thu, 21 Aug 2014 18:38:27 +1000
17+
18 maas (1.6.0+bzr2545-0ubuntu1~ppa1) trusty; urgency=medium
19
20 * New upstream release 1.6.0
21
22=== modified file 'debian/maas-region-controller.postinst'
23--- debian/maas-region-controller.postinst 2014-08-19 16:42:00 +0000
24+++ debian/maas-region-controller.postinst 2014-08-21 08:42:03 +0000
25@@ -21,6 +21,10 @@
26 invoke-rc.d rabbitmq-server restart || true
27 }
28
29+ensure_rabbitmq_started(){
30+ invoke-rc.d rabbitmq-server start || true
31+}
32+
33 restart_postgresql(){
34 invoke-rc.d --force postgresql restart || true
35 }
36@@ -269,8 +273,7 @@
37 ipaddr="$RET"
38 configure_maas_default_url "$ipaddr"
39 configure_maas_squid_deb_proxy "$ipaddr"
40- # make sure rabbitmq is running
41- restart_rabbitmq
42+ ensure_rabbitmq_started
43 configure_maas_txlongpoll_rabbitmq_user
44 if dpkg --compare-versions "$2" lt 1.5+bzr2252-0ubuntu1; then
45 # Handle celery/rabbitmq publishing
46
47=== modified file 'debian/rules'
48--- debian/rules 2014-04-07 14:26:28 +0000
49+++ debian/rules 2014-08-21 08:42:03 +0000
50@@ -53,4 +53,4 @@
51 | sed -rne 's,^Version: ([^-]+).*,\1,p')
52 get-orig-source:
53 bzr export -r $(REV) --root=maas-$(VER).orig \
54- maas_$(VER).orig.tar.gz lp:maas/1.5
55+ maas_$(VER).orig.tar.gz lp:maas/1.6

Subscribers

People subscribed via source and target branches

to all changes: