Merge lp:~julian-edwards/launchpad/remove-lpconfig-bug-598061 into lp:launchpad

Proposed by Julian Edwards
Status: Merged
Approved by: Julian Edwards
Approved revision: no longer in the source branch.
Merged at revision: 11058
Proposed branch: lp:~julian-edwards/launchpad/remove-lpconfig-bug-598061
Merge into: lp:launchpad
Diff against target: 15 lines (+2/-3)
1 file modified
cronscripts/publishing/cron.base-ppa (+2/-3)
To merge this branch: bzr merge lp:~julian-edwards/launchpad/remove-lpconfig-bug-598061
Reviewer Review Type Date Requested Status
Michael Nelson (community) Approve
Review via email: mp+28409@code.launchpad.net

Description of the change

Quick change to remove the setting of LPCONFIG in the base PPA publishing
script. It should come from the crontab or the shell environment instead, and
I'll be landing crontab changes at the same time as (or more likely before)
this,

To post a comment you must log in.
Revision history for this message
Michael Nelson (michael.nelson) :
review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

This is blocked on RT 40044

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cronscripts/publishing/cron.base-ppa'
2--- cronscripts/publishing/cron.base-ppa 2009-06-24 20:52:01 +0000
3+++ cronscripts/publishing/cron.base-ppa 2010-06-24 14:05:49 +0000
4@@ -5,9 +5,8 @@
5
6 # Initial setup for PPA cronscripts.
7
8-# Export LPCONFIG and define common variables.
9-LPCONFIG=ppa
10-export LPCONFIG
11+# DO NOT set LPCONFIG here, it should come from the crontab or the shell.
12+# Define common variables.
13 LPCURRENT=/srv/launchpad.net/codelines/current
14 PPAROOT=/srv/launchpad.net/ppa-archive
15 P3AROOT=/srv/launchpad.net/private-ppa-archive