Launchpad itself

Merge lp:~julian-edwards/launchpad/queue-30 into lp:launchpad

  1. queue-30
  2. Merge into devel
Proposed by Julian Edwards
Status: Merged
Merged at revision: not available
Proposed branch: lp:~julian-edwards/launchpad/queue-30
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~julian-edwards/launchpad/queue-30
Reviewer Review Type Date Requested Status
Michael Nelson (community) ui Approve
Review via email: mp+11189@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
3.0-ify the distroseries queue page

== Proposed fix ==
Easiest mechanical change EVAR.

== Implementation details ==
Simply change the main template and add a top-portlet class to the outer dic.

== Tests ==
bin/test -vvct queue-pages

== Demo and Q/A ==
See https://dogfood.launchpad.net/ubuntu/karmic/+queue

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/templates/distroseries-queue.pt

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Doesn't get much simpler :) It's a shame we won't get to address the functionality issues here.

review: Approve (ui)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/soyuz/templates/distroseries-queue.pt'
2--- lib/lp/soyuz/templates/distroseries-queue.pt 2009-07-19 04:41:14 +0000
3+++ lib/lp/soyuz/templates/distroseries-queue.pt 2009-09-04 10:19:08 +0000
4@@ -3,10 +3,7 @@
5 xmlns:tal="http://xml.zope.org/namespaces/tal"
6 xmlns:metal="http://xml.zope.org/namespaces/metal"
7 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
8- xml:lang="en"
9- lang="en"
10- dir="ltr"
11- metal:use-macro="view/macro:page/onecolumn"
12+ metal:use-macro="view/macro:page/main_only"
13 i18n:domain="launchpad"
14 >
15
16@@ -17,7 +14,7 @@
17 message view/performQueueAction;
18 error view/error|nothing">
19
20- <div class="queue_list" tal:condition="not: error">
21+ <div class="top-portlet queue_list" tal:condition="not: error">
22
23 <tal:batch define="batch view/decoratedQueueBatch|nothing">
24