Launchpad itself

Merge lp:~julian-edwards/launchpad/log-parser-int-overflow-bug-682728 into lp:launchpad/db-devel

  1. log-parser-int-overflow-bug-682728
  2. Merge into db-devel
Proposed by Julian Edwards
Status: Merged
Approved by: Stuart Bishop
Approved revision: no longer in the source branch.
Merged at revision: 10019
Proposed branch: lp:~julian-edwards/launchpad/log-parser-int-overflow-bug-682728
Merge into: lp:launchpad/db-devel
Diff against target: 12 lines (+8/-0)
1 file modified
database/schema/patch-2208-32-0.sql (+8/-0)
To merge this branch: bzr merge lp:~julian-edwards/launchpad/log-parser-int-overflow-bug-682728
Reviewer Review Type Date Requested Status
Stuart Bishop (community) db Approve
Gary Poster (community) Approve
Review via email: mp+42153@code.launchpad.net

Commit message

Make ParsedApacheLog.bytes_read a bigint so that it can cope with larger files.

Description of the change

The PPA Apache log parser is falling over in a heap when it tries to write the bytes_read column of ParsedApacheLog file because the log files are too big to fit in a signed integer field.

This change makes the column a bigint so it can cope with larger files.

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) :
review: Approve
Revision history for this message
Stuart Bishop (stub) wrote :

Fine.

patch-2208-32-0.sql

review: Approve (db)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'database/schema/patch-2208-32-0.sql'
2--- database/schema/patch-2208-32-0.sql 1970-01-01 00:00:00 +0000
3+++ database/schema/patch-2208-32-0.sql 2010-11-30 09:57:53 +0000
4@@ -0,0 +1,8 @@
5+-- Copyright 2010 Canonical Ltd. This software is licensed under the
6+-- GNU Affero General Public License version 3 (see the file LICENSE).
7+SET client_min_messages=ERROR;
8+
9+ALTER TABLE ParsedApacheLog
10+ ALTER COLUMN bytes_read TYPE bigint;
11+
12+INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 32, 0);

Subscribers

People subscribed via source and target branches

to status/vote changes: