Merge lp:~julian-edwards/launchpad/localdiff-sync-bug-739525 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Данило Шеган |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12653 |
Proposed branch: | lp:~julian-edwards/launchpad/localdiff-sync-bug-739525 |
Merge into: | lp:launchpad |
Diff against target: |
175 lines (+65/-21) 3 files modified
lib/lp/registry/browser/distroseries.py (+18/-7) lib/lp/registry/browser/tests/test_series_views.py (+46/-14) lib/lp/testing/factory.py (+1/-0) |
To merge this branch: | bzr merge lp:~julian-edwards/launchpad/localdiff-sync-bug-739525 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | Approve | ||
Review via email: mp+54496@code.launchpad.net |
Commit message
[r=danilo][bug=739525] Derived Distros: Connect the sync button on +localpackagediffs to code that will actually do the sync
Description of the change
= Summary =
Derived Distros feature:
Connect the "Synchronise" button on the +localpackagediffs form to code that will actually perform the diff.
== Implementation details ==
The button was originally left doing nothing, with a stub function. This is because we thought that we needed a job runner to do the synchronisation as package syncing is a fairly db-intensive operation. However, recent improvements to the package copier infrastructure have made it much faster, so we want to try out this direct copying method inside a webapp request (which is exactly how the PPA copying page works).
The code does a very simple call to IArchive.
If we ever need to make this an asynchronous operation, we'll do it in tandem with the PPA copying code, but for now we'll see how it goes like this.
== Tests ==
bin/test -cvv test_series_views
== Demo and Q/A ==
See https:/
(the button doesn't do anything there yet but you can click it to get an idea of how it works)
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
265: E501 line too long (84 characters)
265: Line exceeds 78 characters.
<danilos> bigjools, branch sounds like a nice feature, but you've got a single lint issue so please fix it (I understand it may not be from your changes :)
looking at the code now
<bigjools> :/
<bigjools> it was my lint
<danilos> bigjools, I am sad to see a message like "The following sources *would have been* synced if..." go from the real UI
<bigjools> :)
<wgrant> bigjools: Have you worked out how permissions are going to work?
<bigjools> no
<wgrant> Heh
<danilos> bigjools, r=me, but I'd also remove the "XXX" from a comment about a thing you are not really going to fix unless it proves to be broken