Merge lp:~julian-edwards/launchpad/khtml-border-radius-bug-414759 into lp:launchpad

Proposed by Julian Edwards
Status: Merged
Merged at revision: not available
Proposed branch: lp:~julian-edwards/launchpad/khtml-border-radius-bug-414759
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~julian-edwards/launchpad/khtml-border-radius-bug-414759
Reviewer Review Type Date Requested Status
Deryck Hodge (community) Approve
Review via email: mp+10239@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
Fix CSS for Konqueror rounded border corners
See linked bug.

== Implementation details ==
Konqueror needs different CSS for rounded border corners. We now have 4 ways
of doing this, great huh!

    -khtml-border-radius: 5px;

== Tests ==
None

== Demo and Q/A ==
Fire up Konqueror and look at a side portlet, the new project page is a good
one, e.g.:

https://launchpad.dev/firefox

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/icing/style-3-0.css

Revision history for this message
Deryck Hodge (deryck) wrote :

Hi, Julian.

Looks good to me.

Cheers,
deryck

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
2--- lib/canonical/launchpad/icing/style-3-0.css 2009-08-13 02:24:56 +0000
3+++ lib/canonical/launchpad/icing/style-3-0.css 2009-08-17 11:22:39 +0000
4@@ -28,6 +28,7 @@
5 -moz-border-radius: 0;
6 -o-border-radius: 0;
7 -webkit-border-radius: 0;
8+ -khtml-border-radius: 0;
9 font-size: inherit !important;
10 }
11 #portlets .portlet h2, div.aside h2 {
12@@ -211,6 +212,7 @@
13 padding: 0.8em;
14 -moz-border-radius: 3px 3px 0 0;
15 -webkit-border-radius: 3px 3px 0 0;
16+ -khtml-border-radius: 3px 3px 0 0;
17 border-radius: 3px 3px 0 0;
18 }
19 .footer .lp-arcana img {
20@@ -481,6 +483,7 @@
21 border: 1px solid #dedede;
22 -moz-border-radius: 5px;
23 -webkit-border-radius: 5px;
24+ -khtml-border-radius: 5px;
25 border-radius: 5px;
26 padding: 0.5em;
27 color: #484848;
28@@ -505,6 +508,7 @@
29 border: 1px solid #4f843c;
30 -moz-border-radius: 3px;
31 -webkit-border-radius: 3px;
32+ -khtml-border-radius: 3px;
33 border-radius: 3px;
34 background: #4f843c url(/@@/bg-project-downloads.png) center right no-repeat;
35 padding: 6%;
36@@ -521,6 +525,7 @@
37 .downloads .released span {
38 -moz-border-radius: 0 0 5px 5px;
39 -webkit-border-radius: 0 0 5px 5px;
40+ -khtml-border-radius: 0 0 5px 5px;
41 border-radius: 0 0 5px 5px;
42 background: #d3e3c7;
43 padding: 0.2em 1em;