Launchpad itself

Merge lp:~julian-edwards/launchpad/deathrow-scriptactivity-bug-429315 into lp:launchpad

  1. deathrow-scriptactivity-bug-429315
  2. Merge into devel
Proposed by Julian Edwards
Status: Merged
Approved by: Aaron Bentley
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~julian-edwards/launchpad/deathrow-scriptactivity-bug-429315
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~julian-edwards/launchpad/deathrow-scriptactivity-bug-429315
Reviewer Review Type Date Requested Status
Henning Eggers (community) code Approve
Aaron Bentley (community) Approve
Review via email: mp+11696@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
process death row script is now a LaunchpadCronScript so that it writes to
scriptactivity

== Implementation details ==
s/LaunchpadScript/LaunchpadCronScript/

== Tests ==
n/a

== Demo and Q/A ==

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/scripts/processdeathrow.py

Revision history for this message
Aaron Bentley (abentley) :
review: Approve
Revision history for this message
Henning Eggers (henninge) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/soyuz/scripts/processdeathrow.py'
2--- lib/lp/soyuz/scripts/processdeathrow.py 2009-06-25 04:06:00 +0000
3+++ lib/lp/soyuz/scripts/processdeathrow.py 2009-09-14 13:55:07 +0000
4@@ -20,11 +20,11 @@
5 from zope.component import getUtility
6
7 from lp.archivepublisher.deathrow import getDeathRow
8-from lp.services.scripts.base import LaunchpadScript
9+from lp.services.scripts.base import LaunchpadCronScript
10 from lp.registry.interfaces.distribution import IDistributionSet
11
12
13-class DeathRowProcessor(LaunchpadScript):
14+class DeathRowProcessor(LaunchpadCronScript):
15
16 def add_my_options(self):
17 self.parser.add_option(