Merge lp:~julian-edwards/launchpad/ddeb-override-lockstep into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Данило Шеган | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 14180 | ||||
Proposed branch: | lp:~julian-edwards/launchpad/ddeb-override-lockstep | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
207 lines (+80/-10) 4 files modified
lib/lp/archiveuploader/nascentupload.py (+17/-0) lib/lp/archiveuploader/tests/data/suite/debug_1.0-1/debug_1.0-1_i386.changes (+3/-3) lib/lp/archiveuploader/tests/test_nascentupload.py (+22/-2) lib/lp/archiveuploader/tests/test_uploadprocessor.py (+38/-5) |
||||
To merge this branch: | bzr merge lp:~julian-edwards/launchpad/ddeb-override-lockstep | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | Approve | ||
Review via email: mp+79799@code.launchpad.net |
Commit message
[r=danilo][bug=747558][incr] At upload time, override DDEB files so they are the same as their DEB counterparts. This ensures that domination will work.
Description of the change
= Summary =
At upload time, override DDEB files so they are the same as their DEB counterparts. This ensures that domination will work.
== Pre-implementation notes ==
See comments on bug 747558
== Implementation details ==
Add a new method to the upload processor, "_overrideDDEBSs", that ensures that
any DDEBs in the upload are overridden to have the same
component/
from process().
There are new unit tests for both of these changes. There's also some lint
fixed.
== Tests ==
bin/test -cvv test_nascentupload TestOverrideDDEBs
bin/test -cvv test_test_
== Demo and Q/A ==
Upload some packages that create DDEBs in a PPA and check their overrides.
= Launchpad lint =
Ignore this bogus lint.
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
11: Line has trailing whitespace.
13: Line has trailing whitespace.
17: Line has trailing whitespace.
20: Line has trailing whitespace.
21: Line exceeds 78 characters.
22: Line exceeds 78 characters.
23: Line has trailing whitespace.
25: Line exceeds 78 characters.
The branch looks great.
I wonder if "overriding" component, section and priority means that ddebs will end up in the PPA as well? If they will, will it affect default allocated space to PPAs (i.e. some might hit the limit sooner, or might start hitting the limit once this is rolled out)?