Merge lp:~julian-edwards/launchpad/copy-archive-dispatch-bug-575165 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Julian Edwards |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11569 |
Proposed branch: | lp:~julian-edwards/launchpad/copy-archive-dispatch-bug-575165 |
Merge into: | lp:launchpad |
Diff against target: |
40 lines (+19/-0) 2 files modified
lib/lp/soyuz/model/archive.py (+5/-0) lib/lp/soyuz/tests/test_archive.py (+14/-0) |
To merge this branch: | bzr merge lp:~julian-edwards/launchpad/copy-archive-dispatch-bug-575165 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+35684@code.launchpad.net |
Commit message
Prevent the buildd-manager from falling over when it tries to dispatch COPY archive builds in a release pocket for a released distroseries.
Description of the change
= Summary =
When the buildd-manager dispatches builds it does a last-ditch check to make
sure the build is not getting dispatched for an invalid pocket, such as the
Release pocket in a stable distroseries. (Consider it a belt-and-braces
approach to preventing archive corruption.)
We're currently falling foul of this for COPY archives that are still running
builds when the development distroseries switches to a released state - all of
a sudden perfectly valid builds cause OOPSes in the buildd-manager.
The solution to this is to allow COPY archive uploads to any pocket. We do a
similar thing for the PARTNER archive in fact.
== Implementation details ==
Trivial change and test in the pocket check.
== Tests ==
bin/test -cvvt test_queue
== Demo and Q/A ==
To QA on dogfood:
* Create a few rebuilds on an unreleased distro series and set them off
* Switch the series to released
* Watch the buildd-manager log file and make sure subsequent builds are not
OOPSing when being dispatched.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
Thanks Abel.