Code review comment for lp:~julian-edwards/launchpad/cancel-build-bug-173018-ui-part3

Revision history for this message
Graham Binns (gmb) wrote :

Hi Julian,

Nice branch, just the one comment, otherwise r=me

186 + def test_cancel_not_in_progress(self):
187 + # Testing the cancel() method for a pending build.

195 + def test_cancel_in_progress(self):
196 + # Testing the cancel() method for a building build.

E_LAZY_DEVELOPER: I can figure out what you're testing from the method names - the comments more-or-less repeat that information - but I don't know what the expected behaviour is unless I read the code. Please update the comments so that they tell me what _should_ happen.

review: Approve (code)

« Back to merge proposal