Merge lp:~julian-edwards/launchpad/cancel-build-bug-173018-ui-part3 into lp:launchpad
Proposed by
Julian Edwards
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Julian Edwards | ||||
Approved revision: | 14222 | ||||
Merged at revision: | 14224 | ||||
Proposed branch: | lp:~julian-edwards/launchpad/cancel-build-bug-173018-ui-part3 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
269 lines (+170/-3) 4 files modified
lib/lp/soyuz/interfaces/binarypackagebuild.py (+23/-0) lib/lp/soyuz/model/binarypackagebuild.py (+28/-0) lib/lp/soyuz/stories/webservice/xx-builds.txt (+2/-0) lib/lp/soyuz/tests/test_binarypackagebuild.py (+117/-3) |
||||
To merge this branch: | bzr merge lp:~julian-edwards/launchpad/cancel-build-bug-173018-ui-part3 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+80888@code.launchpad.net |
Commit message
[r=gmb][bug=173018][incr] Add API functionality to cancel virtual builds.
Description of the change
Add BinaryPackageBu
To post a comment you must log in.
Hi Julian,
Nice branch, just the one comment, otherwise r=me
186 + def test_cancel_ not_in_ progress( self):
187 + # Testing the cancel() method for a pending build.
195 + def test_cancel_ in_progress( self):
196 + # Testing the cancel() method for a building build.
E_LAZY_DEVELOPER: I can figure out what you're testing from the method names - the comments more-or-less repeat that information - but I don't know what the expected behaviour is unless I read the code. Please update the comments so that they tell me what _should_ happen.