Merge lp:~julian-edwards/launchpad/buildd-regex-bug-719162 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Leonard Richardson |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12388 |
Proposed branch: | lp:~julian-edwards/launchpad/buildd-regex-bug-719162 |
Merge into: | lp:launchpad |
Diff against target: |
184 lines (+101/-52) 2 files modified
lib/canonical/buildd/check-implicit-pointer-functions (+58/-52) lib/canonical/buildd/tests/test_check_implicit_pointer_functions.py (+43/-0) |
To merge this branch: | bzr merge lp:~julian-edwards/launchpad/buildd-regex-bug-719162 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Leonard Richardson (community) | Approve | ||
Review via email: mp+49796@code.launchpad.net |
Commit message
[r=leonardr][bug=719162] Make buildd pointer check regexes work on natty
Description of the change
= Summary =
Make buildd pointer check regexes work on natty
== Proposed fix ==
64-bit architecture builds have a possible problem with implicit casting of
integers to pointers, which will cause segfaults in the real world. A check
is made for this in the buildds, but unfortunately it's broken on natty
because the regex that's used doesn't pick up the subtle change in compiler
output.
== Pre-implementation notes ==
See the bug.
== Implementation details ==
There's a few changes as I needed to juggle stuff around so that tests could
be written:
* lib/canonical/
lib/canonical/
it for testing
* check-implicit-
function so it doesn't get run when it's imported.
* new tests at
lib/canonical/
== Tests ==
bin/test -cvv test_check_
== Demo and Q/A ==
Quite hard, requires some builds on dogfood/staging to test it, but manual
shell testing shows the script is working fine.