On 31/07/13 16:18, Jeroen T. Vermeulen wrote:
> Review: Approve
>
> Ah, of course it just returned the result from a send() call. Basically the language supports tuples, it's just that it won't let us use them.
>
> Anyway, good branch. The documentation comment for GetContainerProperties is in the imperative — python-style. In Go it should be in the third person, and start with the name of the function.
It's the same for all the functions like that, I kept it consistent. If
we're going to change it, we should do them all at once.
> TestServerError could do with one small change: the c.Check(ok, Equals, true) should be an Assert, because the next check becomes meaningless if you continue — and you'll get a panic drowning out the root cause in the output.
On 31/07/13 16:18, Jeroen T. Vermeulen wrote: perties is in the imperative — python-style. In Go it should be in the third person, and start with the name of the function.
> Review: Approve
>
> Ah, of course it just returned the result from a send() call. Basically the language supports tuples, it's just that it won't let us use them.
>
> Anyway, good branch. The documentation comment for GetContainerPro
It's the same for all the functions like that, I kept it consistent. If
we're going to change it, we should do them all at once.
> TestServerError could do with one small change: the c.Check(ok, Equals, true) should be an Assert, because the next check becomes meaningless if you continue — and you'll get a panic drowning out the root cause in the output.
Right, thanks!