Code review comment for lp:~julian-edwards/gwacl/fix-block-lengths
Revision history for this message
| Julian Edwards (julian-edwards) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
On Monday 05 Aug 2013 10:40:36 you wrote:
> I understand your position but I still like the internal parameter solution.
> Now your tests test two different things: the behavior *and* the size of
> the implicit internal parameter.
I really don't see a problem with increased test coverage. ;)
> If you want to be thorough, I would
> suggest having 2 tests: one that would test the behavior (and that one
> would use the internal parameter) and another one that would test the size
> of the padding.
>
> Now I agree that this might be a bit overkill in this precise situation.
Yes, I think we can agree on that!