Code review comment for lp:~julian-edwards/gwacl/fix-block-lengths

Raphaƫl Badin (rvb) wrote :

Looks good.

[0]

8 + // Block IDs must be a consistent length, so pad it out.
9 + blockID = fmt.Sprintf("%030s", blockID)

I was just wondering about the choice of "30" here but I guess it does not really matter. Maybe worth turning it into a private variable though, especially if you do what I suggest in [1].

[1]

21 - assertBlockSent(c, context, data, b64("0"), transport.Exchanges[0])
22 + assertBlockSent(c, context, data, b64("000000000000000000000000000000"), transport.Exchanges[0])
etc.

Using strings.Repeat would be a bit more elegant here.

review: Approve

« Back to merge proposal