Merge lp:~juhapekka-piiroinen/ubuntu-qtcreator-plugins/add-deviceinfo-to-devices-tab into lp:ubuntu-qtcreator-plugins

Proposed by Juhapekka Piiroinen
Status: Merged
Merged at revision: 183
Proposed branch: lp:~juhapekka-piiroinen/ubuntu-qtcreator-plugins/add-deviceinfo-to-devices-tab
Merge into: lp:ubuntu-qtcreator-plugins
Diff against target: 75 lines (+17/-4)
4 files modified
qtcreator/share/qtcreator/ubuntu/scripts/device_search (+1/-1)
qtcreator/src/plugins/ubuntu/ubuntudeviceswidget.cpp (+7/-2)
qtcreator/src/plugins/ubuntu/ubuntudeviceswidget.ui (+7/-0)
qtcreator/src/plugins/ubuntu/ubuntuprocess.cpp (+2/-1)
To merge this branch: bzr merge lp:~juhapekka-piiroinen/ubuntu-qtcreator-plugins/add-deviceinfo-to-devices-tab
Reviewer Review Type Date Requested Status
Ubuntu SDK team Pending
Review via email: mp+162009@code.launchpad.net

Description of the change

Add device information to Devices -tab.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qtcreator/share/qtcreator/ubuntu/scripts/device_search'
2--- qtcreator/share/qtcreator/ubuntu/scripts/device_search 2013-04-23 11:09:57 +0000
3+++ qtcreator/share/qtcreator/ubuntu/scripts/device_search 2013-05-02 00:51:23 +0000
4@@ -16,4 +16,4 @@
5 # Author: Juhapekka Piiroinen <juhapekka.piiroinen@canonical.com>
6 set -e;
7
8-adb devices
9+adb devices -l
10
11=== modified file 'qtcreator/src/plugins/ubuntu/ubuntudeviceswidget.cpp'
12--- qtcreator/src/plugins/ubuntu/ubuntudeviceswidget.cpp 2013-05-01 22:36:21 +0000
13+++ qtcreator/src/plugins/ubuntu/ubuntudeviceswidget.cpp 2013-05-02 00:51:23 +0000
14@@ -85,15 +85,19 @@
15 QStringList lines = m_reply.trimmed().split(QLatin1String("\n"));
16 lines.takeFirst();
17 foreach(QString line, lines) {
18- QStringList lineData = line.split(QLatin1String("\t"));
19+ QStringList lineData = line.split(QLatin1String(" "));
20 if (lineData.count() == 2) {
21 QString sSerialNumber = lineData.takeFirst();
22+ QString sDeviceInfo = lineData.takeFirst();
23 //QString sDeviceName = lineData.takeFirst();
24
25 //ui->lblDeviceName->setText(sDeviceName.trimmed());
26- ui->comboBoxSerialNumber->addItem(sSerialNumber.trimmed());
27+ ui->comboBoxSerialNumber->addItem(sSerialNumber.trimmed(),sDeviceInfo);
28 //ui->lblSerialnumber->setText(sSerialNumber.trimmed());
29 m_deviceSerialNumber = sSerialNumber.trimmed();
30+
31+ } else {
32+ qDebug() << lineData.count() << lineData;
33 }
34 }
35
36@@ -226,6 +230,7 @@
37 void UbuntuDevicesWidget::on_comboBoxSerialNumber_currentIndexChanged( const QString & text ) {
38 m_deviceSerialNumber = text;
39 if (!text.isEmpty()) {
40+ ui->lblDeviceInfo->setText(ui->comboBoxSerialNumber->itemData(ui->comboBoxSerialNumber->currentIndex()).toString());
41 detectDeviceVersion();
42 }
43 }
44
45=== modified file 'qtcreator/src/plugins/ubuntu/ubuntudeviceswidget.ui'
46--- qtcreator/src/plugins/ubuntu/ubuntudeviceswidget.ui 2013-05-01 22:36:21 +0000
47+++ qtcreator/src/plugins/ubuntu/ubuntudeviceswidget.ui 2013-05-02 00:51:23 +0000
48@@ -182,6 +182,13 @@
49 </widget>
50 </item>
51 <item>
52+ <widget class="QLabel" name="lblDeviceInfo">
53+ <property name="text">
54+ <string/>
55+ </property>
56+ </widget>
57+ </item>
58+ <item>
59 <spacer name="horizontalSpacer_2">
60 <property name="orientation">
61 <enum>Qt::Horizontal</enum>
62
63=== modified file 'qtcreator/src/plugins/ubuntu/ubuntuprocess.cpp'
64--- qtcreator/src/plugins/ubuntu/ubuntuprocess.cpp 2013-04-08 13:34:07 +0000
65+++ qtcreator/src/plugins/ubuntu/ubuntuprocess.cpp 2013-05-02 00:51:23 +0000
66@@ -71,7 +71,8 @@
67 }
68
69 void UbuntuProcess::processReadyRead() {
70- emit message(QString::fromLatin1(m_currentProcess.readAll()));
71+ emit message(QString::fromLatin1(m_currentProcess.readAllStandardError()));
72+ emit message(QString::fromLatin1(m_currentProcess.readAllStandardOutput()));
73 }
74
75 void UbuntuProcess::processCmdQueue() {

Subscribers

People subscribed via source and target branches