QA Tools

Merge lp:~juhapekka-piiroinen/qa-tools/fix-bazaar-hook into lp:qa-tools

  1. fix-bazaar-hook
  2. Merge into trunk
Proposed by Juhapekka Piiroinen
Status: Merged
Approved by: Juhapekka Piiroinen
Approved revision: 2
Merged at revision: 2
Proposed branch: lp:~juhapekka-piiroinen/qa-tools/fix-bazaar-hook
Merge into: lp:qa-tools
Diff against target: 19 lines (+3/-1)
1 file modified
bazaar/plugins/qa-tools-makecheck.py (+3/-1)
To merge this branch: bzr merge lp:~juhapekka-piiroinen/qa-tools/fix-bazaar-hook
Reviewer Review Type Date Requested Status
Michael Zanetti Pending
Review via email: mp+155226@code.launchpad.net

Description of the change

Fixed the typo in question (y/n) to (y/N) to mark the default answer.
Added TODO notes in comments.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bazaar/plugins/qa-tools-makecheck.py'
2--- bazaar/plugins/qa-tools-makecheck.py 2013-03-25 11:54:12 +0000
3+++ bazaar/plugins/qa-tools-makecheck.py 2013-03-25 13:42:25 +0000
4@@ -23,12 +23,14 @@
5
6 print
7 print
8- ask = raw_input("Do you want to execute tests? (y/n): ")
9+ ask = raw_input("Do you want to execute tests? (y/N): ")
10 if (ask != "y" and ask != "Y"):
11 return
12
13 os.chdir(local_path_from_url(master_branch.base))
14
15+ ## TODO: add also a check for cmake based project
16+ ## TODO: check if the project has a .pro file
17 #if not master_branch.basis_tree().has_filename("Makefile"):
18 # if (subprocess.call("qmake -r", shell=True) != 0):
19 # raise errors.BzrError("Unable to run qmake.")

Subscribers

People subscribed via source and target branches