turnip

Merge ~jugmac00/turnip:replace-deprecated-method into turnip:master

  1. Git
  2. lp:~jugmac00/turnip
  3. replace-deprecated-method
  4. Merge into master
Proposed by Jürgen Gmach
Status: Merged
Approved by: Jürgen Gmach
Approved revision: a7e390d749391e11d9eac793f66955339ac22bf4
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~jugmac00/turnip:replace-deprecated-method
Merge into: turnip:master
Diff against target: 13 lines (+1/-1)
1 file modified
turnip/pack/http.py (+1/-1)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+414169@code.launchpad.net

Commit message

replace deprecated base64.decodestring by base64.decodebytes

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Running landing tests failed
https://jenkins.ols.canonical.com/online-services/job/turnip/324/

Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Running landing tests failed
https://jenkins.ols.canonical.com/online-services/job/turnip/326/

Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Running landing tests failed
https://jenkins.ols.canonical.com/online-services/job/turnip/328/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/turnip/pack/http.py b/turnip/pack/http.py
2index 24bb606..037bb58 100644
3--- a/turnip/pack/http.py
4+++ b/turnip/pack/http.py
5@@ -493,7 +493,7 @@ class TurnipAuthCookieSigner(AuthCookieSigner):
6 sha1 = paste.auth.cookie.sha1
7 hmac = paste.auth.cookie.hmac
8 make_time = paste.auth.cookie.make_time
9- decode = base64.decodestring(
10+ decode = base64.decodebytes(
11 cookie.replace(b"_", b"/").replace(b"~", b"="))
12 signature = decode[:_signature_size]
13 expires = decode[_signature_size:_header_size]

Subscribers

People subscribed via source and target branches