Merge ~jugmac00/lpci:fix-deprecation-use_snapshots into lpci:main

Proposed by Jürgen Gmach
Status: Merged
Merged at revision: bec65b122e65f165451d752bc3f1f2a13d7dd5fc
Proposed branch: ~jugmac00/lpci:fix-deprecation-use_snapshots
Merge into: lpci:main
Diff against target: 113 lines (+19/-12)
5 files modified
NEWS.rst (+7/-0)
lpcraft/providers/_lxd.py (+2/-2)
lpcraft/providers/tests/test_lxd.py (+1/-1)
requirements.txt (+8/-8)
setup.cfg (+1/-1)
Reviewer Review Type Date Requested Status
Guruprasad Approve
Review via email: mp+437782@code.launchpad.net

Commit message

Fix deprecation warning in `lxd.launch`

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) wrote :
Revision history for this message
Guruprasad (lgp171188) wrote :

The relevant lines in the changelog are:

> For the LXD launch function launched_environment, the parameter use_snapshots has been replaced by use_base_instance. use_snapshots still works but logs a deprecation notice.

Revision history for this message
Guruprasad (lgp171188) wrote :

LGTM 👍

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/NEWS.rst b/NEWS.rst
2index 86d21cc..2da4038 100644
3--- a/NEWS.rst
4+++ b/NEWS.rst
5@@ -2,6 +2,13 @@
6 Version history
7 ===============
8
9+0.0.46 (unreleased)
10+===================
11+
12+- Update dependencies.
13+
14+- Fix deprecation warning in `lxd.launch` (changed API in `craft-providers`).
15+
16 0.0.45 (2023-02-15)
17 ===================
18
19diff --git a/lpcraft/providers/_lxd.py b/lpcraft/providers/_lxd.py
20index 0d325a6..a2e0927 100644
21--- a/lpcraft/providers/_lxd.py
22+++ b/lpcraft/providers/_lxd.py
23@@ -55,7 +55,7 @@ class _LXDLauncher(Protocol):
24 auto_create_project: bool = False,
25 ephemeral: bool = False,
26 map_user_uid: bool = False,
27- use_snapshots: bool = False,
28+ use_base_instance: bool = False,
29 project: str = "default",
30 remote: str = "local",
31 lxc: lxd.LXC = _lxc_client,
32@@ -305,7 +305,7 @@ class LXDProvider(Provider):
33 auto_clean=True,
34 auto_create_project=True,
35 map_user_uid=True,
36- use_snapshots=True,
37+ use_base_instance=True,
38 project=self.lxd_project,
39 remote=self.lxd_remote,
40 lxc=self.lxc,
41diff --git a/lpcraft/providers/tests/test_lxd.py b/lpcraft/providers/tests/test_lxd.py
42index 5df5fc5..3b32768 100644
43--- a/lpcraft/providers/tests/test_lxd.py
44+++ b/lpcraft/providers/tests/test_lxd.py
45@@ -461,7 +461,7 @@ class TestLXDProvider(TestCase):
46 auto_clean=True,
47 auto_create_project=True,
48 map_user_uid=True,
49- use_snapshots=True,
50+ use_base_instance=True,
51 project="test-project",
52 remote="test-remote",
53 lxc=mock_lxc,
54diff --git a/requirements.txt b/requirements.txt
55index 32ab7f2..9930c45 100644
56--- a/requirements.txt
57+++ b/requirements.txt
58@@ -6,35 +6,35 @@
59 #
60 certifi==2022.12.7
61 # via requests
62-charset-normalizer==2.1.1
63+charset-normalizer==3.0.1
64 # via requests
65 craft-cli==1.2.0
66 # via -r requirements.in
67-craft-providers==1.6.2
68+craft-providers==1.7.2
69 # via -r requirements.in
70 idna==3.4
71 # via requests
72-platformdirs==2.6.0
73+platformdirs==3.0.0
74 # via craft-cli
75 pluggy==1.0.0
76 # via -r requirements.in
77-pydantic==1.10.2
78+pydantic==1.10.5
79 # via
80 # -r requirements.in
81 # craft-cli
82 # craft-providers
83-python-dotenv==0.21.0
84+python-dotenv==0.21.1
85 # via -r requirements.in
86 pyyaml==6.0
87 # via
88 # -r requirements.in
89 # craft-cli
90 # craft-providers
91-requests==2.28.1
92+requests==2.28.2
93 # via requests-unixsocket
94 requests-unixsocket==0.3.0
95 # via craft-providers
96-typing-extensions==4.4.0
97+typing-extensions==4.5.0
98 # via pydantic
99-urllib3==1.26.13
100+urllib3==1.26.14
101 # via requests
102diff --git a/setup.cfg b/setup.cfg
103index 6caa534..290bcff 100644
104--- a/setup.cfg
105+++ b/setup.cfg
106@@ -1,6 +1,6 @@
107 [metadata]
108 name = lpcraft
109-version = 0.0.45
110+version = 0.0.46.dev0
111 description = Runner for Launchpad CI jobs
112 long_description = file: README.rst
113 long_description_content_type = text/x-rst

Subscribers

People subscribed via source and target branches