~jugmac00/lpci:increase-test-coverage

Branch merges

Propose for merging

Merged into lpci:main at revision 5a9fcff8117d566cf8a205d6abec3b59d6a03051

Colin Watson (community): Approve on 2021-11-25

Diff: 436 lines (+204/-17)

15 files modified

.coveragerc (+1/-0)
.gitignore (+1/-0)
lpcraft/commands/run.py (+5/-3)
lpcraft/commands/tests/__init__.py (+8/-1)
lpcraft/commands/tests/test_run.py (+1/-0)
lpcraft/providers/_buildd.py (+1/-1)
lpcraft/providers/_lxd.py (+3/-3)
lpcraft/providers/tests/__init__.py (+1/-4)
lpcraft/providers/tests/test_buildd.py (+9/-0)
lpcraft/providers/tests/test_lxd.py (+23/-4)
lpcraft/providers/tests/test_replay_logs.py (+59/-0)
lpcraft/tests/test_errors.py (+14/-0)
lpcraft/tests/test_main.py (+75/-0)
lpcraft/tests/test_utils.py (+1/-0)
tox.ini (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

5a9fcff... by Jürgen Gmach on 2021-11-25

gitignore build directory

0d6ad3f... by Jürgen Gmach on 2021-11-25

Enforce 100% branch coverage

6a7c7a1... by Jürgen Gmach on 2021-11-25

Ignore coverage temporarily

- in order to get 100% code coverage
- wait until there are better use cases to actually test this code paths

905d789... by Jürgen Gmach on 2021-11-25

Add temporary tests for emitter states

- emitter state does not get used e.g. in the run command, which means
there is not much output to test yet

- the cli design needs to be changed, as currently e.g. `version` and
`--version` act differently when passing in an emitter state from cli

a8c1245... by Jürgen Gmach on 2021-11-24

Add test for failing lxd.configure_buildd_image_remote

7ba407a... by Jürgen Gmach on 2021-11-24

Add missing pipeline entry

ef33926... by Jürgen Gmach on 2021-11-24

Remove unused parts from FakeLXDInstaller

09bfd55... by Jürgen Gmach on 2021-11-24

Skip testing for _RealLXDInstaller

The class and its methods are only implemented to work around a bug in
mypy:
https://github.com/python/mypy/issues/5018

975c677... by Jürgen Gmach on 2021-11-17

Increase test coverage

- Exclude unreachable code from coverage
- Test CommandError's __eq___ method
- Test LPCraftBuilddBaseConfiguration's __eq__ method
- Test instance cannot pull file
- Test replaying logs
- Test keyboard interruption
- LPCraftBuilddBaseConfiguration should be only comparable to same type
- Test handling of unexpected exectptions
- `CommandBaseTestCase.run_command` now also returns `trace` calls

9685923... by Jürgen Gmach on 2021-11-19

Retrieve version info directly from setup.cfg for building snaps