lpci

~jugmac00/lpci:compare-crafterrors-directly

  1. Git
  2. lp:~jugmac00/lpci
  3. compare-crafterrors-directly
Last commit made on 2021-12-01
Get this branch:
git clone -b compare-crafterrors-directly https://git.launchpad.net/~jugmac00/lpci
Only Jürgen Gmach can upload to this branch. If you are Jürgen Gmach please log in for upload directions.

Branch merges

Branch information

Name:
compare-crafterrors-directly
Repository:
lp:~jugmac00/lpci

Recent commits

1fc0863... by Jürgen Gmach

Directly compare CraftErrors

Since https://github.com/canonical/craft-cli/pull/41 has landed, you
can compare CraftError objects directly, so there is no more need to
compare the string representation.

ded4b1e... by Jürgen Gmach

Declare system package dependencies for jobs

a415214... by Jürgen Gmach

Declare snap dependencies for jobs

3b20d4b... by Colin Watson

Check arguments slightly more defensively

cff573f... by Colin Watson

Briefly document new option

616fd00... by Colin Watson

Allow unsetting values via dynamic-properties

eca7b06... by Colin Watson

Remove several unnecessary assertions

4be82d6... by Colin Watson

Simplify some tests

50c134a... by Colin Watson

Rename various things for clarity

bde16fc... by Colin Watson

Handle job output paths and properties

The main complexity here is in ensuring that paths extracted from
completed jobs can't escape the build tree, either directly or via
symlinks.

I added a `LocalExecuteRun` gadget because we now need to do some work
in the container via carefully-crafted `find` and `readlink`
subprocesses, and mocking those meant that we weren't really testing the
interesting bits. Now we at least do real subprocess execution in those
tests, albeit without a container.

`distribute`, `channels`, and `expires` will be implemented on the
Launchpad side.