Merge ~jugmac00/lpci:always-update-repositories into lpci:main

[Jürgen Gmach]

Always update apt cache index

[Colin Watson (cjwatson)]

Your failed test run is at https://launchpad.net/~jugmac00/lpcraft/+git/lpcraft/+build/381, with a coverage failure: looks like you will have to figure out how to test `apt update` vs. `apt install` failures before this can land. I've left a suggestion.

review: Approve

diff --git a/NEWS.rst b/NEWS.rst
index da24023..9e35a13 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -5,7 +5,7 @@ Version history
 0.0.13 (unreleased)
 ===================
 
-- Nothing yet.
+- Always update apt cache index before installing a package.
 
 0.0.12 (2022-05-12)
 ===================
diff --git a/lpcraft/commands/run.py b/lpcraft/commands/run.py
index fc0c80c..106ac2f 100644
--- a/lpcraft/commands/run.py
+++ b/lpcraft/commands/run.py
@@ -278,24 +278,24 @@ def _run_job(
                         group="root",
                         user="root",
                     )
-                # update local repository information
-                apt_update = ["apt", "update"]
-                with emit.open_stream(f"Running {apt_update}") as stream:
-                    proc = instance.execute_run(
-                        apt_update,
-                        cwd=remote_cwd,
-                        env=environment,
-                        stdout=stream,
-                        stderr=stream,
-                    )
-                if proc.returncode != 0:
-                    raise CommandError(
-                        f"Job {job_name!r} for "
-                        f"{job.series}/{host_architecture} failed with "
-                        f"exit status {proc.returncode} "
-                        f"while running `{shlex.join(apt_update)}`.",
-                        retcode=proc.returncode,
-                    )
+            # update local repository information
+            apt_update = ["apt", "update"]
+            with emit.open_stream(f"Running {apt_update}") as stream:
+                proc = instance.execute_run(
+                    apt_update,
+                    cwd=remote_cwd,
+                    env=environment,
+                    stdout=stream,
+                    stderr=stream,
+                )
+            if proc.returncode != 0:
+                raise CommandError(
+                    f"Job {job_name!r} for "
+                    f"{job.series}/{host_architecture} failed with "
+                    f"exit status {proc.returncode} "
+                    f"while running `{shlex.join(apt_update)}`.",
+                    retcode=proc.returncode,
+                )
             packages_cmd = ["apt", "install", "-y"] + packages
             emit.progress("Installing system packages")
             with emit.open_stream(f"Running {packages_cmd}") as stream:
diff --git a/lpcraft/commands/tests/test_run.py b/lpcraft/commands/tests/test_run.py
index df96d69..165d435 100644
--- a/lpcraft/commands/tests/test_run.py
+++ b/lpcraft/commands/tests/test_run.py
@@ -6,7 +6,7 @@ import json
 import os
 import re
 import subprocess
-from pathlib import Path
+from pathlib import Path, PosixPath
 from textwrap import dedent
 from typing import Any, AnyStr, Dict, List, Optional
 from unittest.mock import ANY, Mock, call, patch
@@ -493,7 +493,11 @@ class TestRun(RunBaseTestCase):
         provider = makeLXDProvider(lxd_launcher=launcher)
         mock_get_provider.return_value = provider
         execute_run = launcher.return_value.execute_run
-        execute_run.return_value = subprocess.CompletedProcess([], 100)
+        # `apt update` should pass -> 0
+        # `apt install` should fails -> 100
+        execute_run.side_effect = iter(
+            [subprocess.CompletedProcess([], ret) for ret in (0, 100)]
+        )
         config = dedent(
             """
             pipeline:
@@ -521,7 +525,14 @@ class TestRun(RunBaseTestCase):
                     env={},
                     stdout=ANY,
                     stderr=ANY,
-                )
+                ),
+                call(
+                    ["apt", "install", "-y", "git"],
+                    cwd=PosixPath("/root/lpcraft/project"),
+                    env={},
+                    stdout=ANY,
+                    stderr=ANY,
+                ),
             ],
             execute_run.call_args_list,
         )
@@ -1530,6 +1541,13 @@ class TestRun(RunBaseTestCase):
         self.assertEqual(
             [
                 call(
+                    ["apt", "update"],
+                    cwd=PosixPath("/root/lpcraft/project"),
+                    env={},
+                    stdout=ANY,
+                    stderr=ANY,
+                ),
+                call(
                     [
                         "apt",
                         "install",
@@ -1584,8 +1602,8 @@ class TestRun(RunBaseTestCase):
         self.assertEqual(
             [
                 call(
-                    ["apt", "install", "-y", "unknown_package"],
-                    cwd=Path("/root/lpcraft/project"),
+                    ["apt", "update"],
+                    cwd=PosixPath("/root/lpcraft/project"),
                     env={},
                     stdout=ANY,
                     stderr=ANY,
diff --git a/lpcraft/plugin/tests/test_plugins.py b/lpcraft/plugin/tests/test_plugins.py
index dbdd2c2..cda49e4 100644
--- a/lpcraft/plugin/tests/test_plugins.py
+++ b/lpcraft/plugin/tests/test_plugins.py
@@ -51,6 +51,13 @@ class TestPlugins(CommandBaseTestCase):
         self.assertEqual(
             [
                 call(
+                    ["apt", "update"],
+                    cwd=PosixPath("/root/lpcraft/project"),
+                    env={"TOX_TESTENV_PASSENV": "http_proxy https_proxy"},
+                    stdout=ANY,
+                    stderr=ANY,
+                ),
+                call(
                     [
                         "apt",
                         "install",
@@ -143,6 +150,13 @@ class TestPlugins(CommandBaseTestCase):
         self.assertEqual(
             [
                 call(
+                    ["apt", "update"],
+                    cwd=PosixPath("/root/lpcraft/project"),
+                    env={"TOX_TESTENV_PASSENV": "http_proxy https_proxy"},
+                    stdout=ANY,
+                    stderr=ANY,
+                ),
+                call(
                     [
                         "apt",
                         "install",
@@ -196,6 +210,13 @@ class TestPlugins(CommandBaseTestCase):
         self.assertEqual(
             [
                 call(
+                    ["apt", "update"],
+                    cwd=PosixPath("/root/lpcraft/project"),
+                    env={},
+                    stdout=ANY,
+                    stderr=ANY,
+                ),
+                call(
                     [
                         "apt",
                         "install",