Merge ~jugmac00/lpci:show_error_message_when_no_output_files into lpci:main

[Jürgen Gmach]

Show error message when there are no matching output files

[Colin Watson (cjwatson)]

review: Approve

diff --git a/NEWS.rst b/NEWS.rst
index 03d30e4..7af12cc 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -7,6 +7,9 @@ Version history
 
 - Add note that containers will not be deleted automatically.
 
+- Show error message when there are no matching output files,
+  see https://bugs.launchpad.net/lpcraft/+bug/1962774
+
 0.0.3   (2022-02-23)
 ====================
 
diff --git a/lpcraft/commands/run.py b/lpcraft/commands/run.py
index 8292f47..950549b 100644
--- a/lpcraft/commands/run.py
+++ b/lpcraft/commands/run.py
@@ -107,13 +107,15 @@ def _copy_output_paths(
 
     filtered_paths: Set[PurePath] = set()
     for path_pattern in output.paths:
-        filtered_paths.update(
-            PurePath(name)
-            for name in fnmatch.filter(
-                [str(path) for path in remote_paths],
-                path_pattern,
+        paths = [str(path) for path in remote_paths]
+        result = fnmatch.filter(paths, path_pattern)
+        if not result:
+            raise CommandError(
+                f"{path_pattern} has not matched any output files."
             )
-        )
+        for name in result:
+            filtered_paths.add(PurePath(name))
+
     resolved_paths = _resolve_symlinks(
         instance,
         [remote_cwd / path for path in sorted(filtered_paths)],
diff --git a/lpcraft/commands/tests/test_run.py b/lpcraft/commands/tests/test_run.py
index afc2796..19cb494 100644
--- a/lpcraft/commands/tests/test_run.py
+++ b/lpcraft/commands/tests/test_run.py
@@ -890,6 +890,53 @@ class TestRun(RunBaseTestCase):
     @patch("lpcraft.env.get_managed_environment_project_path")
     @patch("lpcraft.commands.run.get_provider")
     @patch("lpcraft.commands.run.get_host_architecture", return_value="amd64")
+    def test_shows_error_message_when_no_output_files(
+        self,
+        mock_get_host_architecture,
+        mock_get_provider,
+        mock_get_project_path,
+    ):
+        target_path = Path(self.useFixture(TempDir()).path)
+        launcher = Mock(spec=launch)
+        provider = self.makeLXDProvider(lxd_launcher=launcher)
+        mock_get_provider.return_value = provider
+        execute_run = LocalExecuteRun(self.tmp_project_path)
+        launcher.return_value.execute_run = execute_run
+        mock_get_project_path.return_value = self.tmp_project_path
+        config = dedent(
+            """
+            pipeline:
+                - build
+
+            jobs:
+                build:
+                    series: focal
+                    architectures: amd64
+                    run: |
+                        true
+                    output:
+                        paths: ["*.whl"]
+            """
+        )
+        Path(".launchpad.yaml").write_text(config)
+
+        result = self.run_command(
+            "run", "--output-directory", str(target_path)
+        )
+
+        self.assertThat(
+            result,
+            MatchesStructure.byEquality(
+                exit_code=1,
+                errors=[
+                    CommandError("*.whl has not matched any output files.")
+                ],
+            ),
+        )
+
+    @patch("lpcraft.env.get_managed_environment_project_path")
+    @patch("lpcraft.commands.run.get_provider")
+    @patch("lpcraft.commands.run.get_host_architecture", return_value="amd64")
     def test_reads_properties(
         self,
         mock_get_host_architecture,