Merge ~jugmac00/lpci:add-comment-about-pinning-tox-version into lpci:main

Proposed by Jürgen Gmach
Status: Merged
Merged at revision: a3a7a47b530ca7f0794b081c8a25093084593431
Proposed branch: ~jugmac00/lpci:add-comment-about-pinning-tox-version
Merge into: lpci:main
Diff against target: 13 lines (+2/-0)
1 file modified
lpcraft/plugins/plugins.py (+2/-0)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+413804@code.launchpad.net

Commit message

Add todo comment about pinning tox

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

Thanks for the review!

I filed an issue with the spell checker which did not mark this as a typo.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lpcraft/plugins/plugins.py b/lpcraft/plugins/plugins.py
2index 0438598..cf5862b 100644
3--- a/lpcraft/plugins/plugins.py
4+++ b/lpcraft/plugins/plugins.py
5@@ -28,6 +28,8 @@ class ToxPlugin:
6
7 @hookimpl # type: ignore
8 def lpcraft_execute_run(self) -> str:
9+ # XXX jugmac00 2022-01-07: we should consider using a requirements.txt
10+ # as this allows updating via `pip-tools`
11 return "python3 -m pip install tox==3.24.5; tox"
12
13 @hookimpl # type: ignore

Subscribers

People subscribed via source and target branches