fix-charm-reciped-cannot-be-deleted : lp:~jugmac00/launchpad : Git : Code : Launchpad itself

Get this branch:: git clone -b fix-charm-reciped-cannot-be-deleted https://git.launchpad.net/~jugmac00/launchpad

Only Jürgen Gmach can upload to this branch. If you are Jürgen Gmach please log in for upload directions.

Branch merges

Branch information

Name:: fix-charm-reciped-cannot-be-deleted

Repository:: lp:~jugmac00/launchpad

Recent commits

2824232... by Jürgen Gmach on 2022-04-08

Fix charm recipes cannot be deleted

`CharmRecipe.destroySelf` failed as there was still a reference on
`CharmRecipeBuildJob`.

This has been fixed now.

7f26f20... by Colin Watson on 2022-04-07

Make build system compatible with virtualenv 20

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/418654

a5418e0... by Colin Watson on 2022-04-07

Make build system compatible with virtualenv 20

virtualenv 20 was a complete rewrite of virtualenv. It's mostly
compatible with older versions, but there were some places where
Launchpad ran into trouble with it:

* The handling of the `sitecustomize` module is a little different, and
we rely on that to load some Launchpad customizations.

* `env/bin/python3` is now a symlink (indirectly) to
   `/usr/bin/python3`, rather than being a copy of it, so we can't rely
   on touching it for timestamp comparison purposes in the `Makefile`.
   Use `env/instance_name` (which we were already creating for other
   reasons in `setup.py`) for this instead.

* We now have to set the `VIRTUAL_ENV` environment variable in
`_pythonpath.py` to activate the virtual environment properly.

* While initially debugging this, I removed an unnecessary `$(PY)` from
   the invocation of `utilities/create-lp-wadl-and-apidoc.py`, and
   tidied up the `#!` line of `utilities/js-deps` to match all our other
   virtualenv-using scripts. These changes turn out not to be strictly
   required to support virtualenv 20, but I kept them since they seem
   like reasonable improvements in passing.

16bcc21... by Colin Watson on 2022-04-07