Merge ~jugmac00/launchpad:prevent-email-disclosure into launchpad:master
Proposed by
Jürgen Gmach
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jürgen Gmach | ||||
Approved revision: | e2c4848ab0dd8c6a6a8d75f29b796202f4f99027 | ||||
Merge reported by: | Otto Co-Pilot | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~jugmac00/launchpad:prevent-email-disclosure | ||||
Merge into: | launchpad:master | ||||
Diff against target: |
134 lines (+41/-16) 4 files modified
lib/lp/registry/model/distributionmirror.py (+5/-4) lib/lp/registry/tests/test_distributionmirror.py (+15/-7) lib/lp/translations/scripts/po_import.py (+2/-5) lib/lp/translations/scripts/tests/test_translations_import.py (+19/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+412672@code.launchpad.net |
Commit message
Prevent email address disclosure for mirror notifications
Description of the change
This is WIP:
There are a couple of more possibly problematic spots.
https:/
https:/
https:/
To post a comment you must log in.
This looks good as far as it goes.
https:/ /git.launchpad. net/launchpad/ tree/lib/ lp/soyuz/ mail/binarypack agebuild. py#n166 isn't a problem: an SPR's creator is a single person.
The importer in https:/ /git.launchpad. net/launchpad/ tree/lib/ lp/translations /scripts/ po_import. py#n145 sometimes ends up being ~rosetta-admins, which is a large team, so let's add a loop there.
https:/ /git.launchpad. net/launchpad/ tree/lib/ lp/translations /scripts/ translations_ to_branch. py#n297 is marginal, but I'd be inclined to leave it alone, at least for now; I think the case where a team explicitly owns something is a bit different from the mirror-admins and rosetta-admins cases where the ownership is rather more, um, ambient.