Merge ~jugmac00/launchpad:signedcodeofconduct-cant-be-null into launchpad:db-devel

Proposed by Jürgen Gmach
Status: Merged
Approved by: Jürgen Gmach
Approved revision: 67c791c7b597e2d09d059177bd30ec3b3214c7aa
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~jugmac00/launchpad:signedcodeofconduct-cant-be-null
Merge into: launchpad:db-devel
Diff against target: 14 lines (+8/-0)
1 file modified
database/schema/patch-2210-34-1.sql (+8/-0)
Reviewer Review Type Date Requested Status
William Grant db Approve
Colin Watson (community) db Approve
Review via email: mp+410433@code.launchpad.net

Commit message

signedcodeofconduct.affirmed can`t be NULL anymore

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Ioana has already claimed this patch number (in https://bazaar.launchpad.net/~launchpad/+junk/dbpatches/view/head:/allocated.txt) for RevisionStatus{Report,Artifact}. Please use 2210-34-1 instead, since this is following on directly from the addition of this column in 2210-34-0 and no later patch touches SignedCodeOfConduct. I've allocated this patch number for you.

review: Needs Fixing (db)
Revision history for this message
Jürgen Gmach (jugmac00) wrote (last edit ):

Thank you for the review!

Thanks for the reference to https://bazaar.launchpad.net/~launchpad/+junk/dbpatches/view/head:/allocated.txt - it makes sense to claim a number in advance.

Also, thank you for explaining how to use the number scheme - now it makes sense on how to use it.

I also updated the header and the footer.

Revision history for this message
Colin Watson (cjwatson) wrote :

Needs a second DB review from William, but LGTM.

review: Approve (db)
Revision history for this message
William Grant (wgrant) :
review: Approve (db)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/database/schema/patch-2210-34-1.sql b/database/schema/patch-2210-34-1.sql
2new file mode 100644
3index 0000000..1816936
4--- /dev/null
5+++ b/database/schema/patch-2210-34-1.sql
6@@ -0,0 +1,8 @@
7+-- Copyright 2021 Canonical Ltd. This software is licensed under the
8+-- GNU Affero General Public License version 3 (see the file LICENSE).
9+
10+SET client_min_messages=ERROR;
11+
12+ALTER TABLE signedcodeofconduct ALTER COLUMN affirmed SET NOT NULL;
13+
14+INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 34, 1);

Subscribers

People subscribed via source and target branches

to status/vote changes: