Merge lp:~jtv/maas/resolve_hostname into lp:~maas-committers/maas/trunk
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2833 |
Proposed branch: | lp:~jtv/maas/resolve_hostname |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
169 lines (+125/-1) 2 files modified
src/provisioningserver/utils/network.py (+44/-0) src/provisioningserver/utils/tests/test_network.py (+81/-1) |
To merge this branch: | bzr merge lp:~jtv/maas/resolve_hostname |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Julian Edwards (community) | Approve | ||
Review via email: mp+232372@code.launchpad.net |
Commit message
New networking helper: resolve_hostname.
Description of the change
This is preparation for an IPv6 branch that is about to go up for separate review. In order to support sending DNS server addresses to DHCPv6 clients I had to pry apart the implementation of get_maas_
Is it time to introduce an enum for IPv4/IPv6? It'd have to go into provisioningser
Jeroen
> provisioningser ver.enum
I know I keep saying it, but a common third library would be awesome :/
AF_INET[6] sounds fine enough for me though, it's pretty generic.