Merge lp:~jtv/maas/pkg-bug-1376620 into lp:~maas-maintainers/maas/packaging

Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: no longer in the source branch.
Merged at revision: 316
Proposed branch: lp:~jtv/maas/pkg-bug-1376620
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 15 lines (+5/-3)
1 file modified
debian/maas-cluster-controller.templates (+5/-3)
To merge this branch: bzr merge lp:~jtv/maas/pkg-bug-1376620
Reviewer Review Type Date Requested Status
Graham Binns (community) Approve
Review via email: mp+236837@code.launchpad.net

Commit message

The maas-url config item is used not just to let cluster controllers find the region API, but to let nodes find it as well. At least one user thought they could use 127.0.0.1 in the URL, which will typically work for the cluster controller but not for the nodes.

Description of the change

I also made it say “region controller” rather than “server” as the counterpart to “cluster controller.”

Jeroen

To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) wrote :

I think there's still a risk of folk just not getting that 127.0.0.1 / localhost just isn't a valid host. Why not:

 "The MAAS cluster controller and nodes need to contact the MAAS region controller API. Set the URL at which they can reach the MAAS API here, e.g. http://192.168.1.1/MAAS.
  Note that this URL must be accessible outside of the region controller machine, so localhost or 127.0* are not valid hostnames here."

(That sentence needs some polish, but you get my meaning.)

Revision history for this message
Graham Binns (gmb) wrote :

(Oops, forgot the approval…)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/maas-cluster-controller.templates'
2--- debian/maas-cluster-controller.templates 2012-10-03 05:53:38 +0000
3+++ debian/maas-cluster-controller.templates 2014-10-02 09:58:33 +0000
4@@ -2,6 +2,8 @@
5 Type: string
6 Default:
7 _Description: Ubuntu MAAS API address:
8- The MAAS Cluster Controller needs to contact the MAAS server to
9- register its presence. Set the URL to the MAAS API here, e.g.
10- http://192.168.1.1/MAAS
11+ The MAAS cluster controller and nodes need to contact the MAAS region
12+ controller API. Set the URL at which they can reach the MAAS API remotely,
13+ e.g. http://192.168.1.1/MAAS
14+ Since nodes must be able to access this URL, localhost or 127.0.0.1 are not
15+ useful values here.

Subscribers

People subscribed via source and target branches