Code review comment for lp:~jtv/maas/pkg-bug-1086239

Revision history for this message
Julian Edwards (julian-edwards) wrote :

20 +pre-start script
21 + if [ ! -f $CONFIG_FILE ]; then
22 + echo "$CONFIG_FILE does not exist. Aborting."

You've not set CONFIG_FILE anywhere.

47 + grep "^CLUSTER_UUID *= *[\"'][^\"']*[\"']" $config_file |
48 + sed -e "s/^CLUSTER_UUID *= *\"\([^\"']*\)\".*/\1/"

MY EYES. THEY BURN.

78 + # Write it to maas_cluster.conf as well. There is no initial
79 + # placeholder in this file, so just append the setting.
80 + echo "CLUSTER_UUID=\"$uuid\"" >>/etc/maas/maas_cluster.conf

This will duplicate lines every time the package is upgraded.

review: Needs Fixing

« Back to merge proposal