Merge lp:~jtv/maas/no-public-keys-is-not-an-error into lp:~maas-committers/maas/trunk
Proposed by
Jeroen T. Vermeulen
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1166 |
Proposed branch: | lp:~jtv/maas/no-public-keys-is-not-an-error |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
95 lines (+18/-20) 2 files modified
src/metadataserver/api.py (+10/-13) src/metadataserver/tests/test_api.py (+8/-7) |
To merge this branch: | bzr merge lp:~jtv/maas/no-public-keys-is-not-an-error |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Badin (community) | Approve | ||
Review via email:
|
Commit message
If a node requests its public-keys but there are none, just return a success response without any keys. The tracebacks were distracting, and may or may not have affected commissioning.
Description of the change
Julian ran into the traceback when commissioning. Commissioning was broken for apparently unrelated reasons, but we might as well eliminate the error from our list of suspects.
Jeroen
To post a comment you must log in.
This has annoyed me for ages! Thanks for tackling this. lgtm