Merge lp:~jtv/maas/ipv6-ngi-layout into lp:~maas-committers/maas/trunk

Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: no longer in the source branch.
Merged at revision: 2874
Proposed branch: lp:~jtv/maas/ipv6-ngi-layout
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 27 lines (+3/-3)
2 files modified
src/maasserver/enum.py (+2/-2)
src/maasserver/templates/maasserver/nodegroup_edit.html (+1/-1)
To merge this branch: bzr merge lp:~jtv/maas/ipv6-ngi-layout
Reviewer Review Type Date Requested Status
Raphaël Badin (community) Approve
Review via email: mp+233003@code.launchpad.net

Commit message

Narrow down the cluster interfaces listing in the UI, so it doesn't get scrunched up as the columns fill up with longer values.

With IPv6 networks I started seeing layout problems. The “Manage DHCP and DNS” management indicator gets broken into two lines. It probably gets worse if you have a foreign DHCP server as well.

To fix that, I shortened the contents of the management column. Instead of saying “Status” at the top of the column (which wasn't right anyway) I made it say “Manage...” The entries then say just “DHCP” or “DHCP and DNS” where before they said “Manage DHCP” or “Manage DHCP and DNS.”

Description of the change

This may not be good UI design. But I wanted to try something and get some feedback at least, rather than be stuck with the problem.

Example of the old layout (not even at its worst; no foreign DHCP servers): http://people.canonical.com/~jtv/ngis-scrunched.png

Example of the new layout (with foreign DHCP servers): http://people.canonical.com/~jtv/ngis-narrower.png

Jeroen

To post a comment you must log in.
Revision history for this message
Raphaël Badin (rvb) wrote :

Looks good, thanks for the screenshots.

Not sure I like the "..." at the end of the header though, it looks a bit odd. Maybe "Manage" would be enough.

review: Approve
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

> Not sure I like the "..." at the end of the header though, it looks a bit odd.
> Maybe "Manage" would be enough.

Yeah, it's a tough one. Without it, it's not clear that you need to read it differently. Then you'd need something like "Management" — but not exactly that because it doesn't make sense. I just couldn't come up with a better term.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/enum.py'
2--- src/maasserver/enum.py 2014-09-01 09:29:38 +0000
3+++ src/maasserver/enum.py 2014-09-02 09:07:48 +0000
4@@ -171,8 +171,8 @@
5 # representation).
6 NODEGROUPINTERFACE_MANAGEMENT_CHOICES = (
7 (NODEGROUPINTERFACE_MANAGEMENT.UNMANAGED, "Unmanaged"),
8- (NODEGROUPINTERFACE_MANAGEMENT.DHCP, "Manage DHCP"),
9- (NODEGROUPINTERFACE_MANAGEMENT.DHCP_AND_DNS, "Manage DHCP and DNS"),
10+ (NODEGROUPINTERFACE_MANAGEMENT.DHCP, "DHCP"),
11+ (NODEGROUPINTERFACE_MANAGEMENT.DHCP_AND_DNS, "DHCP and DNS"),
12 )
13
14
15
16=== modified file 'src/maasserver/templates/maasserver/nodegroup_edit.html'
17--- src/maasserver/templates/maasserver/nodegroup_edit.html 2014-07-18 17:05:57 +0000
18+++ src/maasserver/templates/maasserver/nodegroup_edit.html 2014-09-02 09:07:48 +0000
19@@ -27,7 +27,7 @@
20 <th>Name</th>
21 <th>Interface</th>
22 <th>Network</th>
23- <th>Status</th>
24+ <th>Manage...</th>
25 <th>Non-MAAS DHCP</th>
26 <th></th>
27 </tr>