Merge lp:~jtv/maas/ipv6-ngi-layout into lp:~maas-committers/maas/trunk
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2874 |
Proposed branch: | lp:~jtv/maas/ipv6-ngi-layout |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
27 lines (+3/-3) 2 files modified
src/maasserver/enum.py (+2/-2) src/maasserver/templates/maasserver/nodegroup_edit.html (+1/-1) |
To merge this branch: | bzr merge lp:~jtv/maas/ipv6-ngi-layout |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Badin (community) | Approve | ||
Review via email: mp+233003@code.launchpad.net |
Commit message
Narrow down the cluster interfaces listing in the UI, so it doesn't get scrunched up as the columns fill up with longer values.
With IPv6 networks I started seeing layout problems. The “Manage DHCP and DNS” management indicator gets broken into two lines. It probably gets worse if you have a foreign DHCP server as well.
To fix that, I shortened the contents of the management column. Instead of saying “Status” at the top of the column (which wasn't right anyway) I made it say “Manage...” The entries then say just “DHCP” or “DHCP and DNS” where before they said “Manage DHCP” or “Manage DHCP and DNS.”
Description of the change
This may not be good UI design. But I wanted to try something and get some feedback at least, rather than be stuck with the problem.
Example of the old layout (not even at its worst; no foreign DHCP servers): http://
Example of the new layout (with foreign DHCP servers): http://
Jeroen
Looks good, thanks for the screenshots.
Not sure I like the "..." at the end of the header though, it looks a bit odd. Maybe "Manage" would be enough.