MAAS

Merge lp:~jtv/maas/fix-broken-js-test-hardcoded-status into lp:~maas-committers/maas/trunk

  1. fix-broken-js-test-hardcoded-status
  2. Merge into trunk
Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: no longer in the source branch.
Merged at revision: 3096
Proposed branch: lp:~jtv/maas/fix-broken-js-test-hardcoded-status
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
src/maasserver/static/js/tests/test_node_views.js (+1/-1)
To merge this branch: bzr merge lp:~jtv/maas/fix-broken-js-test-hardcoded-status
Reviewer Review Type Date Requested Status
Raphaël Badin (community) Approve
Review via email: mp+236055@code.launchpad.net

Commit message

Fix a hard-coded status in a JS test. We don't have Selenium enabled at the moment, but when I enable it, it breaks here because the enum value has changed.

Description of the change

No point keeping this waiting until we figure out the Selenium problem. It makes the test pass.

Jeroen

To post a comment you must log in.
Revision history for this message
Raphaël Badin (rvb) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/static/js/tests/test_node_views.js'
2--- src/maasserver/static/js/tests/test_node_views.js 2014-09-01 09:36:07 +0000
3+++ src/maasserver/static/js/tests/test_node_views.js 2014-09-26 04:11:27 +0000
4@@ -327,7 +327,7 @@
5
6 view.updateNode('updated', node);
7 Y.Assert.areEqual(
8- 6,
9+ Y.maas.enums.NODE_STATUS.ALLOCATED,
10 view.modelList.getById('sys1').get('status'),
11 "The node should have been updated.");
12 Y.Assert.areEqual(