Merge lp:~jtv/maas/disable-rabbit-tests into lp:~maas-committers/maas/trunk

Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: no longer in the source branch.
Merged at revision: 1610
Proposed branch: lp:~jtv/maas/disable-rabbit-tests
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 27 lines (+3/-0)
1 file modified
src/maasserver/tests/test_rabbit.py (+3/-0)
To merge this branch: bzr merge lp:~jtv/maas/disable-rabbit-tests
Reviewer Review Type Date Requested Status
Gavin Panella (community) Approve
Review via email: mp+185780@code.launchpad.net

Commit message

Temporarily disable TestRabbitMessaging tests (as per bug 1225980).

Description of the change

See bug 1225980 for the details. We should re-enable this as soon as possible.

Jeroen

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

Can you use the unittest.skip decorator instead of commenting out the code? There are existing examples in the tree.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/tests/test_rabbit.py'
2--- src/maasserver/tests/test_rabbit.py 2013-09-13 10:10:55 +0000
3+++ src/maasserver/tests/test_rabbit.py 2013-09-17 04:24:36 +0000
4@@ -15,6 +15,7 @@
5
6 import socket
7 import time
8+from unittest import skip
9
10 from amqplib import client_0_8 as amqp
11 from django.conf import settings
12@@ -78,6 +79,7 @@
13
14 class TestRabbitMessaging(MAASTestCase):
15
16+ @skip("XXX bug=1225980: This breaks on the lander.")
17 @uses_rabbit_fixture
18 def test_messaging_getExchange(self):
19 exchange_name = factory.getRandomString()
20@@ -87,6 +89,7 @@
21 self.assertEqual(messaging._session, exchange._session)
22 self.assertEqual(exchange_name, exchange.exchange_name)
23
24+ @skip("XXX bug=1225980: This breaks on the lander.")
25 @uses_rabbit_fixture
26 def test_messaging_getQueue(self):
27 exchange_name = factory.getRandomString()