Merge lp:~jtv/maas/cap-ipv6-deployment-ubuntu into lp:~maas-committers/maas/trunk

Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: no longer in the source branch.
Merged at revision: 3004
Proposed branch: lp:~jtv/maas/cap-ipv6-deployment-ubuntu
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 60 lines (+12/-2)
4 files modified
docs/capabilities.rst (+6/-0)
docs/index.rst (+1/-1)
docs/ipv6.rst (+3/-1)
src/maasserver/api/version.py (+2/-0)
To merge this branch: bzr merge lp:~jtv/maas/cap-ipv6-deployment-ubuntu
Reviewer Review Type Date Requested Status
Newell Jensen (community) Approve
Review via email: mp+234904@code.launchpad.net

Commit message

Define and document a new capability: ipv6-deployment-ubuntu.

Also, move the link to the IPv6 documentation to a more appropriate place in the documentation index. Right below ‘networks’ is wrong because that document is about networks for placement-constraint purposes, not about setting up networking.

Description of the change

It's tempting to call the capability just “ipv6,” but I think a capability of that name would make more sense for the point where the whole basic feature works. Instead I went with something more specific for what is now possible: deploy Ubuntu nodes with IPv6 enabled.

We may at some point support deploying over IPv6, which might create confusion with deployment of IPv6-capable nodes. A capability for exclusively IPv6-based deployment might be called something like pure-ipv6-deployment, or it might come with pure IPv6 commissioning as well, in which case it might be ipv6-provisioning.

Jeroen

To post a comment you must log in.
Revision history for this message
Newell Jensen (newell-jensen) wrote :

Looks good to me. Not sure if this is going to create more work for you or someone else later when the "whole basic feature works" if it would need to be changed to not be as specific as what you have here.

Revision history for this message
Newell Jensen (newell-jensen) :
review: Approve
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Thanks! As we get more IPv6 features working, we can just add capabilities for them. Once we feel confident in answering "yes, we support IPv6!" the time will be right for a plain "ipv6" capability.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'docs/capabilities.rst'
2--- docs/capabilities.rst 2014-08-22 00:13:24 +0000
3+++ docs/capabilities.rst 2014-09-17 02:43:26 +0000
4@@ -29,3 +29,9 @@
5 Passive modelling of the network environment that cluster controllers
6 nodes are in, including network interfaces, subnets, VLAN tags, and
7 connectivity between them. See :ref:`networks` for more information.
8+
9+.. _cap-ipv6-deployment-ubuntu:
10+
11+``ipv6-deployment-ubuntu``
12+ Deploy Ubuntu nodes with IPv6 networking enabled. See :ref:`ipv6` for more
13+ about this feature.
14
15=== modified file 'docs/index.rst'
16--- docs/index.rst 2014-09-16 07:24:19 +0000
17+++ docs/index.rst 2014-09-17 02:43:26 +0000
18@@ -54,11 +54,11 @@
19 install
20 configure
21 cluster-configuration
22+ ipv6
23 bootsources
24 nodes
25 hardware-enablement-kernels
26 networks
27- ipv6
28 kernel-options
29 installing-ubuntu
30
31
32=== modified file 'docs/ipv6.rst'
33--- docs/ipv6.rst 2014-09-16 11:35:02 +0000
34+++ docs/ipv6.rst 2014-09-17 02:43:26 +0000
35@@ -8,7 +8,9 @@
36 .. note::
37
38 This feature is available in MAAS versions 1.7 and above, starting with
39- lp:maas revision 2992.
40+ lp:maas revision 2992. If you're writing a client application that makes use
41+ of this feature, you can query the region-server API for the
42+ ``ipv6-deployment-ubuntu`` :ref:`capability<cap-ipv6-deployment-ubuntu>`.
43
44 MAAS has limited IPv6 support for networking nodes. It works much like IPv4
45 support, but with a number of limitations:
46
47=== modified file 'src/maasserver/api/version.py'
48--- src/maasserver/api/version.py 2014-08-18 13:18:46 +0000
49+++ src/maasserver/api/version.py 2014-09-17 02:43:26 +0000
50@@ -24,10 +24,12 @@
51 # MAAS capabilities. See docs/capabilities.rst for documentation.
52 CAP_NETWORKS_MANAGEMENT = 'networks-management'
53 CAP_STATIC_IPADDRESSES = 'static-ipaddresses'
54+CAP_IPv6_DEPLOYMENT_UBUNTU = 'ipv6-deployment-ubuntu'
55
56 API_CAPABILITIES_LIST = [
57 CAP_NETWORKS_MANAGEMENT,
58 CAP_STATIC_IPADDRESSES,
59+ CAP_IPv6_DEPLOYMENT_UBUNTU,
60 ]
61
62