Merge lp:~jtv/maas/bug-991553 into lp:~maas-committers/maas/trunk
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jeroen T. Vermeulen | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 541 | ||||
Proposed branch: | lp:~jtv/maas/bug-991553 | ||||
Merge into: | lp:~maas-committers/maas/trunk | ||||
Diff against target: |
45 lines (+16/-5) 2 files modified
HACKING.txt (+8/-3) INSTALL.txt (+8/-2) |
||||
To merge this branch: | bzr merge lp:~jtv/maas/bug-991553 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Julian Edwards (community) | Approve | ||
Review via email: mp+104328@code.launchpad.net |
Commit message
Documentation patch: run maas-import-isos with your current http_proxy setting.
Description of the change
As requested by Julian after contribution from Scott. This updates our documentation for the benefit of people who want to run maas-import-isos from behind an http proxy. Running the script in “sudo” gives it an environment without variables such as http_proxy that you might have set in your shell.
Other ways of doing this would include “sudo su” or “sudo -i” (both of which would create a root login environment, including any http_proxy setting from /etc/profile). But what if you run the script on a server that's not normally supposed to talk http to the outside world? The http_proxy setting might be local to your current shell, or might not normally be set for root. Either way, I think this spelling makes the issue explicit. Even if you simply forgot to set http_proxy, this will remind you to set it.
Jeroen
8 - $ sudo ./scripts/ maas-import- isos $http_proxy ./scripts/ maas-import- isos
9 + $ sudo http_proxy=
You could do with the same explanation of the proxy here as in INSTALL.txt, otherwise looks great, thanks!