MAAS

Merge lp:~jtv/maas/bug-975435 into lp:~maas-committers/maas/trunk

  1. bug-975435
  2. Merge into trunk
Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: no longer in the source branch.
Merged at revision: 429
Proposed branch: lp:~jtv/maas/bug-975435
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 13 lines (+7/-1)
1 file modified
etc/cron.d/maas-gc (+7/-1)
To merge this branch: bzr merge lp:~jtv/maas/bug-975435
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+101331@code.launchpad.net

Commit message

Document maas-gc cron job.

Description of the change

As reported by Jamie: the maas-gc cron job needs a meaningful description. No functional change.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Looks much better, thanks. I'd also mention that the uploaded files are there as part of the file storage API, currently only used by Juju but will store commissioning logs at some point.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'etc/cron.d/maas-gc'
2--- etc/cron.d/maas-gc 2012-04-02 20:14:49 +0000
3+++ etc/cron.d/maas-gc 2012-04-10 09:13:22 +0000
4@@ -1,2 +1,8 @@
5-# Runs 'maas gc' every day at midnight
6+# Perform daily background cleanups in MAAS.
7+#
8+# The "maas gc" command is for garbage-collection, such as deleting uploaded
9+# files from Juju's file storage API, and in the future commissioning logs,
10+# that have been superseded by newer ones. (This isn't done immediately
11+# when the files are overwritten because (1) the transaction that overwrites
12+# them may fail, and (2) a file may still be in use when it's overwritten.)
13 0 0 * * * root /usr/sbin/maas gc &> /dev/null