Merge lp:~jtv/maas/bug-1376990-js-test-lint into lp:~maas-committers/maas/trunk
Proposed by
Jeroen T. Vermeulen
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jeroen T. Vermeulen | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 3189 | ||||
Proposed branch: | lp:~jtv/maas/bug-1376990-js-test-lint | ||||
Merge into: | lp:~maas-committers/maas/trunk | ||||
Diff against target: |
47 lines (+6/-6) 1 file modified
src/maasserver/static/js/tests/test_image_views.js (+6/-6) |
||||
To merge this branch: | bzr merge lp:~jtv/maas/bug-1376990-js-test-lint | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Reis (community) | Approve | ||
Blake Rouse (community) | Approve | ||
Review via email: mp+236985@code.launchpad.net |
Commit message
Fix some lint in a JavaScript test. The JS lint checker doesn't always show these things, but when it does, it makes development difficult.
Description of the change
Inconsistent lint reports mean that we have to jump in and fix lint when we see it — the author of the code will have checked for lint but not gotten any reports.
Another part of the lint fix is to follow. The part you see here should be uncontroversial: only a test is affected, and it's a known browser compatibility pitfall — a trailing comma after the last element in an array or object breaks hard in IE (or at least it used to, not all that long ago).
Jeroen
To post a comment you must log in.
Thanks.