Merge lp:~jtv/maas/bug-1299374 into lp:~maas-committers/maas/trunk
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2206 |
Proposed branch: | lp:~jtv/maas/bug-1299374 |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
303 lines (+75/-58) 4 files modified
src/maasserver/models/nodegroup.py (+2/-2) src/maasserver/models/nodegroupinterface.py (+29/-30) src/maasserver/models/tests/test_nodegroupinterface.py (+42/-25) src/maasserver/rpc/tests/test_regionservice.py (+2/-1) |
To merge this branch: | bzr merge lp:~jtv/maas/bug-1299374 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Julian Edwards (community) | Approve | ||
Review via email: mp+213367@code.launchpad.net |
Commit message
Make NodeGroupInterf
Description of the change
When I had to re-install my testing MAAS today, I was forced to enter a broadcast IP for a managed cluster interface. That's just silly. With perhaps some strange exceptions that sysadmins would know about, a network's broadcast address is simply the last IP address in the network's range — the one that has all host bits set to one. You're never forced to enter it anywhere because given a network's address and size, the standard value is obvious.
Nor did it make much sense to derive the network information from the interface's broadcast address. The interface's own network address has to be on the same network, and is required, so we might as well use that. There is nothing special about the broadcast address in this regard.
There was one strange thing with this branch. When I ran tests, the Selenium tests failed, as they always do on this system. But in addition to this, I got a failure in TestRegionService: test_stopping_
It looks like a test isolation error. All test cases in test_regionserv
Jeroen
Nice!