Merge lp:~jtv/maas/bug-1233069 into lp:~maas-committers/maas/trunk
Proposed by
Jeroen T. Vermeulen
| Status: | Merged |
|---|---|
| Merged at revision: | 1651 |
| Proposed branch: | lp:~jtv/maas/bug-1233069 |
| Merge into: | lp:~maas-committers/maas/trunk |
| Diff against target: |
41 lines (+12/-5) 1 file modified
scripts/maas-import-pxe-files (+12/-5) |
| To merge this branch: | bzr merge lp:~jtv/maas/bug-1233069 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Raphaël Badin (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Make maas-import-
Description of the change
Previously I made the script a bit more tolerant about missing files, but this change makes it skip images that are not available at all. We notice this when the attempt to download its MD5 checksums fails.
There are no unit-tests for this. Not that we usually unit-test shell code, but in this case it should be possible. It's just that we're working towards replacing this script altogether. I did test it manually, in various combinations of available and unavailable release series.
Failing downloads will still break the ephemerals import script, but we're fixing that with the Python version of the script.
Jeroen
To post a comment you must log in.
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | # |
Revision history for this message
| MAAS Lander (maas-lander) wrote | # |
Revision history for this message
| MAAS Lander (maas-lander) wrote | # |
Revision history for this message
| MAAS Lander (maas-lander) wrote | # |
Download full text (205.5 KiB)
Revision history for this message
| MAAS Lander (maas-lander) wrote | # |
Download full text (18.4 KiB)
Revision history for this message
| MAAS Lander (maas-lander) wrote | # |
Download full text (731.4 KiB)
Revision history for this message
| MAAS Lander (maas-lander) wrote | # |
Download full text (10.1 KiB)
Revision history for this message
| MAAS Lander (maas-lander) wrote | # |
Download full text (558.5 KiB)
Revision history for this message
| MAAS Lander (maas-lander) wrote | # |
Download full text (436.0 KiB)
Revision history for this message
| MAAS Lander (maas-lander) wrote | # |
Download full text (543.9 KiB)
Revision history for this message
| MAAS Lander (maas-lander) wrote | # |
Download full text (89.5 KiB)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good!
[0]
32 + if ! ignore=$(gpg --keyring=
You can probably get rid of the 'ignore' variable entirely, can't you?