Code review comment for lp:~jtv/maas/bug-1075597

Revision history for this message
Julian Edwards (julian-edwards) wrote :

81 + django.core.urlresolvers.set_script_prefix(self.script_name)

It took me a while to work out where self.script_name was set and then realised it's part of the test scenarios. It might be worth passing it into this function (patch_script_prefix) as a parameter otherwise it looks like the usual testing antipattern stuff.

Everything else looks good. Cheers.

review: Approve

« Back to merge proposal