Merge lp:~jtv/maas-test/quiet-dhcp-check into lp:maas-test

[Jeroen T. Vermeulen]

Remove unhelpful message from DHCP check when interface has no IP address.

As suggested by Julian. If the interface has no IP address, there could still be a DHCP server out there but it's less likely.

Jeroen

[Raphaël Badin (rvb)]

review: Approve

=== modified file 'maastest/detect_dhcp.py'
--- maastest/detect_dhcp.py	2013-12-12 09:54:04 +0000
+++ maastest/detect_dhcp.py	2014-01-09 10:54:41 +0000
@@ -1,4 +1,4 @@
-# Copyright 2013 Canonical Ltd.  This software is licensed under the
+# Copyright 2013-2014 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Discover DHCP servers on your network.
@@ -212,8 +212,10 @@
     # send out repeated requests.
     transaction_id = request_dhcp(interface)
     if transaction_id is None:
-        logging.info(
-            "Network interface %s has no IP address.  "
-            "Can't scan for DHCP servers.", interface)
+        # Network interface has no IP address.  Our DHCP detection code does
+        # not work for this case.
+        # This is a low-priority case because if there were a DHCP server on
+        # the network this interface is attached to, it might well have an IP
+        # address in the first place.
         return set()
     return receive_offers(transaction_id)