Merge lp:~jtv/maas-test/fix-streams-url-option into lp:maas-test

Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: 153
Merged at revision: 150
Proposed branch: lp:~jtv/maas-test/fix-streams-url-option
Merge into: lp:maas-test
Diff against target: 58 lines (+11/-4)
4 files modified
maastest/maasfixture.py (+2/-1)
maastest/main.py (+1/-1)
maastest/parser.py (+7/-2)
maastest/tests/test_maasfixture.py (+1/-0)
To merge this branch: bzr merge lp:~jtv/maas-test/fix-streams-url-option
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+215102@code.launchpad.net

Commit message

Repeat a last change from my previous branch, replacing the --daily-images option with --image-stream-url; I must have pushed it to the wrong place, or not at all.

Description of the change

This was actually part of the review changes to my last branch, and part of the manual testing, so I'll just self-approve it. Otherwise things are horribly broken.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Yup, all stuff I did before. It works now.

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :
Download full text (43.3 KiB)

The attempt to merge lp:~jtv/maas-test/fix-streams-url-option into lp:maas-test failed. Below is the output from the failed tests.

Ign http://security.ubuntu.com saucy-security InRelease
Ign http://nova.clouds.archive.ubuntu.com saucy InRelease
Get:1 http://security.ubuntu.com saucy-security Release.gpg [933 B]
Ign http://nova.clouds.archive.ubuntu.com saucy-updates InRelease
Get:2 http://security.ubuntu.com saucy-security Release [49.6 kB]
Hit http://nova.clouds.archive.ubuntu.com saucy Release.gpg
Get:3 http://nova.clouds.archive.ubuntu.com saucy-updates Release.gpg [933 B]
Hit http://nova.clouds.archive.ubuntu.com saucy Release
Get:4 http://nova.clouds.archive.ubuntu.com saucy-updates Release [49.6 kB]
Hit http://nova.clouds.archive.ubuntu.com saucy/main Sources
Hit http://nova.clouds.archive.ubuntu.com saucy/universe Sources
Hit http://nova.clouds.archive.ubuntu.com saucy/main amd64 Packages
Hit http://nova.clouds.archive.ubuntu.com saucy/universe amd64 Packages
Hit http://nova.clouds.archive.ubuntu.com saucy/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy/universe Translation-en
Get:5 http://security.ubuntu.com saucy-security/main Sources [40.2 kB]
Get:6 http://security.ubuntu.com saucy-security/universe Sources [8,834 B]
Get:7 http://security.ubuntu.com saucy-security/main amd64 Packages [108 kB]
Get:8 http://security.ubuntu.com saucy-security/universe amd64 Packages [36.9 kB]
Hit http://security.ubuntu.com saucy-security/main Translation-en
Hit http://security.ubuntu.com saucy-security/universe Translation-en
Ign http://security.ubuntu.com saucy-security/main Translation-en_US
Get:9 http://nova.clouds.archive.ubuntu.com saucy-updates/main Sources [81.8 kB]
Get:10 http://nova.clouds.archive.ubuntu.com saucy-updates/universe Sources [68.6 kB]
Get:11 http://nova.clouds.archive.ubuntu.com saucy-updates/main amd64 Packages [225 kB]
Get:12 http://nova.clouds.archive.ubuntu.com saucy-updates/universe amd64 Packages [159 kB]
Ign http://security.ubuntu.com saucy-security/universe Translation-en_US
Hit http://nova.clouds.archive.ubuntu.com saucy-updates/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com saucy-updates/universe Translation-en
Ign http://nova.clouds.archive.ubuntu.com saucy/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy/universe Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy-updates/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com saucy-updates/universe Translation-en_US
Fetched 829 kB in 0s (2,232 kB/s)
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
cpu-checker is already the newest version.
python-distro-info is already the newest version.
python-fixtures is already the newest version.
python-lxml is already the newest version.
python-mock is already the newest version.
python-netaddr is already the newest version.
python-netifaces is already the newest version.
python-six is already the newest version.
python-testresources is already the newest version.
python-testtools is already the newest version.
python3-fixtures is already the newest version.
python3-lxml is already the newes...

153. By Jeroen T. Vermeulen

Collateral damage: another test notices the extra parameter.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'maastest/maasfixture.py'
2--- maastest/maasfixture.py 2014-04-10 07:32:35 +0000
3+++ maastest/maasfixture.py 2014-04-10 10:39:35 +0000
4@@ -366,7 +366,8 @@
5 # controllers, and so on.
6 self.import_maas_images(
7 series=self.series, architecture=self.architecture,
8- simplestreams_filter=self.simplestreams_filter)
9+ simplestreams_filter=self.simplestreams_filter,
10+ image_stream_url=self.image_stream_url)
11 self.wait_until_boot_images_scanned()
12 self.configure_default_series(self.series)
13 if self.kvm_fixture.direct_ip is not None:
14
15=== modified file 'maastest/main.py'
16--- maastest/main.py 2014-03-03 04:27:57 +0000
17+++ maastest/main.py 2014-04-10 10:39:35 +0000
18@@ -259,7 +259,7 @@
19 from maastest.maasfixture import MAASFixture
20 fixture = MAASFixture(
21 machine, proxy_url=proxy_url, series=args.series,
22- architecture=args.architecture,
23+ architecture=args.architecture, image_stream_url=args.image_stream_url,
24 simplestreams_filter=args.simplestreams_filter)
25 fixture.install_maas()
26 return fixture
27
28=== modified file 'maastest/parser.py'
29--- maastest/parser.py 2014-04-10 07:02:05 +0000
30+++ maastest/parser.py 2014-04-10 10:39:35 +0000
31@@ -148,8 +148,13 @@
32 help="Node's CPU architecture, e.g. armhf/highbank or amd64. "
33 "Defaults to %(default)s.")
34 parser.add_argument(
35- '--daily-images', action='store_true',
36- help="Use the \"daily\" boot images stream instead of \"release\".")
37+ '--image-stream-url', type=text_type,
38+ help="Simplestreams URL where boot images can be downloaded. "
39+ "Defaults to the release images at "
40+ "http://maas.ubuntu.com/images/ephemeral-v2/releases/ - but "
41+ "daily images of released and unreleased versions of Ubuntu "
42+ "are available at "
43+ "http://maas.ubuntu.com/images/ephemeral-v2/daily/")
44
45 # Proxy.
46 parser.add_argument(
47
48=== modified file 'maastest/tests/test_maasfixture.py'
49--- maastest/tests/test_maasfixture.py 2014-04-10 07:32:35 +0000
50+++ maastest/tests/test_maasfixture.py 2014-04-10 10:39:35 +0000
51@@ -696,6 +696,7 @@
52 [mock.call(
53 series=maas_fixture.series,
54 architecture=maas_fixture.architecture,
55+ image_stream_url=maas_fixture.image_stream_url,
56 simplestreams_filter=maas_fixture.simplestreams_filter)],
57 [mock.call()],
58 ],

Subscribers

People subscribed via source and target branches