LAZR Javascript Library

Merge lp:~jtv/lazr-js/bug-427263 into lp:lazr-js

  1. bug-427263
  2. Merge into toolchain
Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~jtv/lazr-js/bug-427263
Merge into: lp:lazr-js
Diff against target: 21 lines (+2/-2)
1 file modified
examples/inlineeditor/index.html (+2/-2)
To merge this branch: bzr merge lp:~jtv/lazr-js/bug-427263
Reviewer Review Type Date Requested Status
Michael Nelson (community) code Approve
Review via email: mp+14846@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

= Bug 427263 =

In Konqueror, the edit icon for the multi-line inline editor does not show. As Michael found, that is the fate of all empty <a> tags in this browser.

This branch solves that particular problem by inserting a zero-width joiner in the <a> tag. This doesn't produce any visible text (and it has no width), but it's enough to make Konqueror render the tag.

This does not solve any of the myriad other problems with Konqueror: on 4.3.2 I get plentiful test failures, even though basic editing works; and 3.x versions don't work with the widget at all.

Jeroen

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Great find Jeroen!

So I'm guessing we'll need to update the text edit widget in LP to include &zwnj?

As discussed, in lib/canonical/widgets/lazrjs.py:

    TRIGGER_TEMPLATE = dedent(u"""\
        <a href="%(edit_url)s" class="yui-editable_text-trigger sprite edit"
        ></a>
        """)

review: Approve (code)
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

> So I'm guessing we'll need to update the text edit widget in LP to include
> &zwnj?

See the launchpad branch attached to this bug. :-)

lp:~jtv/lazr-js/bug-427263 updated
149. By Jeroen T. Vermeulen

New record: conflict in a one-line change.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/inlineeditor/index.html'
2--- examples/inlineeditor/index.html 2009-11-13 20:47:13 +0000
3+++ examples/inlineeditor/index.html 2009-11-14 00:00:33 +0000
4@@ -50,7 +50,7 @@
5 <div id="multi-text-editor">
6 <div class="clearfix">
7 <div class="edit-controls">
8- <a href="#edit" class="yui-editable_text-trigger edit"></a>
9+ <a href="#edit" class="yui-editable_text-trigger edit">&zwnj;</a>
10 </div>
11 <h2>Description</h2>
12 </div>
13@@ -70,7 +70,7 @@
14 <div id="multi-text-editor">
15 <div class="clearfix">
16 <div class="edit-controls">
17- <a href="#edit" class="yui-editable_text-trigger edit"></a>
18+ <a href="#edit" class="yui-editable_text-trigger edit">&zwnj;</a>
19 </div>
20 <h2>Description</h2>
21 </div>

Subscribers

People subscribed via source and target branches