Merge lp:~jtv/launchpad/recife-another-testfix into lp:~launchpad/launchpad/recife
| Status: | Merged |
|---|---|
| Merged at revision: | 9142 |
| Proposed branch: | lp:~jtv/launchpad/recife-another-testfix |
| Merge into: | lp:~launchpad/launchpad/recife |
| Diff against target: |
16 lines (+1/-1) 1 file modified
lib/lp/translations/tests/test_setcurrenttranslation.py (+1/-1) |
| To merge this branch: | bzr merge lp:~jtv/launchpad/recife-another-testfix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Henning Eggers (community) | code | 2010-07-06 | Approve on 2010-07-06 |
|
Review via email:
|
|||
Commit Message
Another test fix for recife branch (db-stable changes break test).
Description of the Change
= Another Recife test fix =
Fixes a test failure in our recife feature branch that creeps in when merging the latest db-stable into it.
As far as I can see, there's been a change in the outcome of:
>>> series = factory.
>>> print series == ubuntu.
The test did the equivalent of:
>>> new_series = factory.
>>> template1 = factory.
... distroseries=
>>> template2 = factory.
... distroseries=
This passes just fine on the current recife branch, but after merging db-stable into the branch, violates a database unique constraint on POTemplate(
The solution is easy and works either way: don't create new_series until we need it.
To test,
{{{
./bin/test -vv -m lp.translations
}}}
No lint, apart from silly import warnings about /usr/share/
Jeroen
