Merge lp:~jtv/launchpad/post-827347 into lp:launchpad

Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: William Grant
Approved revision: no longer in the source branch.
Merged at revision: 13752
Proposed branch: lp:~jtv/launchpad/post-827347
Merge into: lp:launchpad
Diff against target: 17 lines (+3/-3)
1 file modified
lib/lp/registry/templates/distroseries-portlet-derivation.pt (+3/-3)
To merge this branch: bzr merge lp:~jtv/launchpad/post-827347
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+72376@code.launchpad.net

Commit message

[r=wgrant][bug=827347] Missed a spot in previous branch.

Description of the change

= Summary =

Fix up a bit I missed in a previous UI change.

== Proposed fix ==

On the DistroSeries page for a derived series, the links to differences from parent series were linked as "ⓘ <1234 packages only in a parent>" but to accommodate changes to the text, we changed this to "ⓘ 1234 packages <only in a parent>".

I missed a spot though: the link for packages only in the derived series itself is still in the old format. "ⓘ <2345 packages only in Oneiric>". This branch makes that conform to the other links.

== Pre-implementation notes ==

As discussed intensively with Julian and Raphaël, complete with mockups. It's just my implementation that was lacking.

== Implementation details ==

There is no ⓘ. In the real UI that's just a sprite.

== Tests ==

{{{
./bin/test -vvc lp.registry.browser.tests -t series -t deriv
}}}

== Demo and Q/A ==

Have a look at https://dogfood.launchpad.net/ubuntu/oneiric/ and you should see three more or less consistent lines of references to package differences. (Well, the first line is different but that's deliberate).

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/templates/distroseries-portlet-derivation.pt

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/templates/distroseries-portlet-derivation.pt'
2--- lib/lp/registry/templates/distroseries-portlet-derivation.pt 2011-08-18 11:55:52 +0000
3+++ lib/lp/registry/templates/distroseries-portlet-derivation.pt 2011-08-22 03:50:18 +0000
4@@ -45,10 +45,10 @@
5 </a>
6 </li>
7 <li class="sprite info" tal:condition="nb_diffs_in_child">
8+ <tal:differences_count replace="view/wordDifferencesInChild">
9+ 345 packages
10+ </tal:differences_count>
11 <a tal:attributes="href view/link_to_differences_in_child">
12- <tal:differences_count replace="view/wordDifferencesInChild">
13- 345 packages
14- </tal:differences_count>
15 only in
16 <tal:child replace="context/displayname">
17 Natty