Merge lp:~jtv/launchpad/more-820456 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Graham Binns |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13703 |
Proposed branch: | lp:~jtv/launchpad/more-820456 |
Merge into: | lp:launchpad |
Diff against target: |
85 lines (+3/-43) 3 files modified
lib/lp/registry/browser/distroseries.py (+0/-21) lib/lp/registry/browser/tests/test_distroseries.py (+1/-17) lib/lp/registry/templates/distroseries-localdifferences.pt (+2/-5) |
To merge this branch: | bzr merge lp:~jtv/launchpad/more-820456 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+71689@code.launchpad.net |
Commit message
[r=gmb][bug=820456] Never hide the search box on +localpackagediffs.
Description of the change
= Summary =
If a distroseries shares packages with its parents, and any of those packages has a version difference between the series and its parent that needs attention, the series page will link to DistroSeries:
This search box tries to stay hidden if there are no interesting differences. But that happens when there are no differences except ones that are resolved or permanently-
== Proposed fix ==
Don't hide the search box. There's no point.
== Pre-implementation notes ==
There are other problems: this still won't make the link to the +localpackagediffs appear in cases where there are no differences that need attention. We filed that as bug 827347; it can be done separately and requires a bit of UI design.
== Implementation details ==
Of all my Launchpad branches, this one's been the most fun ever.
== Tests ==
{{{
./bin/test -vvc lp.registry.
}}}
== Demo and Q/A ==
Hack your way into a DistroSeries:
Or: initialize a distroseries from a parent, run ISDJs/PCJs/DSDJs, and hack your way to the +localpackagediffs page. You'll be able to show resolved differences.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/