Merge lp:~jtv/launchpad/get_derived_distros into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13495 |
Proposed branch: | lp:~jtv/launchpad/get_derived_distros |
Merge into: | lp:launchpad |
Diff against target: |
230 lines (+68/-47) 5 files modified
lib/lp/registry/interfaces/distribution.py (+8/-1) lib/lp/registry/model/distribution.py (+11/-1) lib/lp/registry/tests/test_distribution.py (+47/-1) lib/lp/soyuz/scripts/processaccepted.py (+1/-16) lib/lp/soyuz/tests/test_processaccepted.py (+1/-28) |
To merge this branch: | bzr merge lp:~jtv/launchpad/get_derived_distros |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Review via email: mp+68675@code.launchpad.net |
Commit message
Move finding of derived distros into IDistributionSet.
Description of the change
= Summary =
I recently added an option to process-accepted: "process all derived distributions (not counting Ubuntu, even if it is technically derived from Ubuntu)."
Now I'm adding a similar option to publish-distro, so the ability to find all derived distributions should be in a reusable place.
== Proposed fix ==
IDistributionSe
== Pre-implementation notes ==
The notion "derived distributions" is a bit vague in this case. It doesn't matter for the foreseeable future; we're currently thinking "Ubuntu-derived distros" but we're not planning to set up any other derived distros (except perhaps Ubuntu as a derivative of Debian).
It's important that Ubuntu not be included in the list of "derived distributions" because it's large and needs to be processed separately. That's the whole point.
== Implementation details ==
I was unable to find any unit tests for DistributionSet, so I added one.
== Tests ==
{{{
./bin/test -vvc lp.registry.
./bin/test -vvc lp.soyuz.
}}}
== Demo and Q/A ==
There isn't much to demo or Q/A, really; existing code has moved a bit. Just so long as "process-accepted --derived" still runs.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Looks like a sensible move of the code.